Extract words-of-inspiration + tips into cider-inspiration.el#3911
Merged
Conversation
cider-util.el is meant to be small cross-cutting utilities, but a ~160-line block at the bottom held the random connect-greeting quotes (cider-words-of-inspiration) and the keybinding tips list (cider-tips), plus the trivial pickers around them (cider-random-words-of-inspiration, cider-inspire-me, cider-random-tip, cider-drink-a-sip, cider-user-first-name). All data + trivial random selectors, nothing to do with general utilities. Move that block to its own file. Three modules consume these: - cider.el calls cider-random-words-of-inspiration (default for cider-connection-message-fn) and cider-random-tip (via the docs). - cider-mode.el and cider-repl.el reference cider-drink-a-sip in keybindings. Each gets an explicit (require 'cider-inspiration); cider-util.el no longer carries this data. cider-util.el drops from 905 to 742 lines. cider-inspiration.el is 203 lines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cider-util.el is meant to be small cross-cutting utilities, but a ~160-line block at the bottom held the random connect-greeting quotes (
cider-words-of-inspiration) and the keybinding tips list (cider-tips), plus the trivial pickers around them (cider-random-words-of-inspiration,cider-inspire-me,cider-random-tip,cider-drink-a-sip,cider-user-first-name). All data + trivial random selectors, nothing to do with general utilities.Move that block to its own
cider-inspiration.el.Three modules consume these:
cider.el—cider-random-words-of-inspiration(default forcider-connection-message-fn) andcider-random-tipcider-mode.elandcider-repl.el—cider-drink-a-sip(referenced in keybindings)Each gets an explicit
(require 'cider-inspiration). cider-util.el no longer carries this data.cider-util.el: 905 → 742 lines. cider-inspiration.el: 203 lines.
(Also includes a small
.gitignorechange for.claude/— unrelated, but bundled in this PR.)eldev compile --warnings-as-errorseldev test)