cider--completing-read-port: Default to 7888#3918
Merged
Merged
Conversation
Member
|
I'm OK with the proposal. Can you rebase the PR on top of |
Whilst 7888 isn't the official port (see nrepl/nrepl#6 discussion), it's frequently used in practice. Set that as the default value in the minibuffer if we couldn't infer a port. Most nREPL implementations do create a `.nrepl-port` file but it's nice to have 7888 suggested to save a few keystrokes.
Wilfred
force-pushed
the
default-nrepl-port
branch
from
9f9a89a to
f01b9ee
Compare
Contributor
Author
|
Done :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whilst 7888 isn't the official port (see nrepl/nrepl#6 discussion), it's frequently used in practice. Set that as the default value in the minibuffer if we couldn't infer a port.
Most nREPL implementations do create a
.nrepl-portfile but it's nice to have 7888 suggested to save a few keystrokes.eldev test)eldev lint) which is based onelisp-lintand includescheckdoc, check-declare, packaging metadata, indentation, and trailing whitespace checks.