ADD many missing clojure.core macros to font-lock declaration #623
Conversation
|
CI fail is unrelated to my changes, i dono what to do |
clojure-mode.el
Outdated
| "with-open" "with-local-vars" "binding" | ||
| "with-redefs" "with-redefs-fn" | ||
| "declare") t) | ||
| '("->" "->>" ".." "amap" "and" "areduce" "as->" "assert" "binding" |
There was a problem hiding this comment.
While we're here we could leave use one line per item, that way it should be easier to tell whether something's there
(agreed, @bbatsov ?)
There was a problem hiding this comment.
I'm fine with with a name per line, although that'd makes things a bit inconsistent with the rest of the font-locking code.
boxxxie
force-pushed
the
add-missing-macro-font-locks
branch
from
b62269a to
1632b36
Compare
clojure-mode.el
Outdated
| "cond->>" | ||
| "condp" | ||
| "declare" | ||
| "definline" |
There was a problem hiding this comment.
You can remove all the defsomething macros as they are handled in a special manner above. fn is handle there as well.
|
Don't forget to add a changelog entry about this as well. |
boxxxie
force-pushed
the
add-missing-macro-font-locks
branch
from
1632b36 to
4559d91
Compare
|
One more thing - if some of those are duplicated in |
"amap" "areduce" "assert" "bound-fn" "comment" "definline" "definterface" "defmethod" "defmulti" "defn-" "defonce" "defprotocol" "defrecord" "defstruct" "deftype" "delay" "extend-protocol" "extend-type" "fn" "future" "gen-class" "gen-interface" "import" "io!" "lazy-cat" "lazy-seq" "let" "locking" "loop" "memfn" "proxy" "proxy-super" "pvalues" "refer-clojure" "reify" "some->" "some->>" "sync" "time" "vswap!" "while" "with-bindings" "with-in-str" "with-loading-context" "with-out-str" "with-precision" remove duplicated non-special form font locks from special form def: "let" "loop" remove duplicated font locks symbols from clojure-mode-extra-font-locking "amap" "areduce" "as->" "assert" "bound-fn" "comment" "delay" "extend-protocol" "extend-type" "future" "gen-interface" "io!" "lazy-cat" "lazy-seq" "locking" "memfn" "proxy" "proxy-super" "pvalues" "refer-clojure" "reify" "some->" "some->>" "sync" "time" "while" "with-bindings" "with-in-str" "with-loading-context" "with-out-str" "with-precision"
boxxxie
force-pushed
the
add-missing-macro-font-locks
branch
from
4559d91 to
47fea53
Compare
|
Seems good to me. Thanks! |
#622
font locks added