Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nbb support #642

Merged
merged 2 commits into from
Dec 3, 2022
Merged

Nbb support #642

merged 2 commits into from
Dec 3, 2022

Conversation

ikappaki
Copy link
Contributor

@ikappaki ikappaki commented Dec 3, 2022

Add support for nbb including test, addresses #641

HI @borkdude, I've provisionally added nbb in the intrerpreter-mode-alist as something that could appear in the shebang so that clojure mode can pick the script as cljs file, but couldn't find any example using this. Is this a valid case?

Thanks


Before submitting a PR mark the checkboxes for the items you've done (if you
think a checkbox does not apply, then leave it unchecked):

  • The commits are consistent with our [contribution guidelines][1].
  • You've added tests (if possible) to cover your change(s). Bugfix, indentation, and font-lock tests are extremely important!
  • You've run M-x checkdoc and fixed any warnings in the code you've written.
  • You've updated the changelog (if adding/changing user-visible functionality).
  • You've updated the readme (if adding/changing user-visible functionality).

Thanks!

@ikappaki
Copy link
Contributor Author

ikappaki commented Dec 3, 2022

I've noticed that emacs-28 was missing from the CI and I took the opportunity to add it, let me know if you would like me to revert.

Btw, whya are the circleci failing on master? some auth key might have expired? Thanks

@borkdude
Copy link

borkdude commented Dec 3, 2022

It might be a valid use case, but I haven't seen it a lot either.

@bbatsov
Copy link
Member

bbatsov commented Dec 3, 2022

Btw, whya are the circleci failing on master? some auth key might have expired? Thanks

I thought I had fixed this already.

@bbatsov bbatsov merged commit a70c5fc into clojure-emacs:master Dec 3, 2022
@bbatsov
Copy link
Member

bbatsov commented Dec 3, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants