Add clojure-ts-toplevel-inside-comment-form #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes clojure-emacs#30 This is the equivalent to clojure-toplevel-inside-comment-form in clojure-mode
|
I like the proposed change. I'd suggest mentioning in the README as well, so it'd be easier for users to discover it. |
bbatsov
reviewed
Feb 7, 2024
clojure-ts-mode.el
Outdated
| "Eval top level forms inside comment forms instead of the comment form itself." | ||
| :type 'boolean | ||
| :safe #'booleanp | ||
| :package-version '(clojure-ts-mode . "0.3.0")) |
There was a problem hiding this comment.
You're too fast. After I wrote my remark I remembered that this package used a different versioning from what I normally do. :D "0.2.1" would be better.
kommen
force-pushed
the
defun-inside-comment-form
branch
from
5d71824 to
090867e
Compare
|
Can you also mention it here https://github.com/clojure-emacs/clojure-ts-mode?tab=readme-ov-file#configuration? |
|
Yeah, that's enough. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30
clojure-ts-toplevel-inside-comment-formis the equivalent toclojure-toplevel-inside-comment-formin clojure-mode. Defaults tonilso no change in behavior by default.This change makes use of
treesit-defun-type-regexps ability to use(REGEXP . PRED)cons cells to rejectcommentas a defun ifclojure-ts-toplevel-inside-comment-formis enabled.