Support nested indentation rules#70
Merged
bbatsov merged 1 commit intoApr 4, 2025
Merged
Conversation
44af05e to
a0aca89
Compare
bbatsov
reviewed
Apr 4, 2025
bbatsov
reviewed
Apr 4, 2025
bbatsov
reviewed
Apr 4, 2025
Member
Yeah, that's fine. Perhaps we can eventually teach CIDER (and maybe Great change overall! |
a0aca89 to
ec50b30
Compare
bbatsov
approved these changes
Apr 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully the final piece that concerns semantic indentation.
This change generalize the way we detect indentation for macros and special forms and adds support for nested indentation rules (so, for example, separate function
clojure-ts--match-method-bodyis not needed anymore).I changed to format of
clojure-ts-semantic-indent-rules(hopefully it's OK for the version that has not been yet officially released) from(:block n)to((:block n))or optionally((:block n) (:inner n)), which is more consistent with cljfmt format.New format allows defining rules like
("letfn" . ((:block 1) (:inner 2 0)))).clojure-ts--dynamic-indent-for-symbolnow converts not only top level rule, but the entire spec.Before submitting a PR mark the checkboxes for the items you've done (if you
think a checkbox does not apply, then leave it unchecked):
M-x checkdocand fixed any warnings in the code you've written.Thanks!