Skip to content

Introduce cycle privacy refactoring command #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rrudakov
Copy link
Contributor

@rrudakov rrudakov commented May 4, 2025

Before submitting a PR mark the checkboxes for the items you've done (if you
think a checkbox does not apply, then leave it unchecked):

  • The commits are consistent with our contribution guidelines.
  • You've added tests (if possible) to cover your change(s). Bugfix, indentation, and font-lock tests are extremely important!
  • You've run M-x checkdoc and fixed any warnings in the code you've written.
  • You've updated the changelog (if adding/changing user-visible functionality).
  • You've updated the readme (if adding/changing user-visible functionality).

Thanks!

@rrudakov rrudakov force-pushed the feature/cycle-privacy-refactoring branch from a296a77 to a8d9795 Compare May 4, 2025 18:40
@rrudakov rrudakov force-pushed the feature/cycle-privacy-refactoring branch from a8d9795 to ae99174 Compare May 4, 2025 19:46
@rrudakov rrudakov requested a review from bbatsov May 4, 2025 19:47
@rrudakov rrudakov force-pushed the feature/cycle-privacy-refactoring branch from ae99174 to 142e3f7 Compare May 4, 2025 19:49
@bbatsov
Copy link
Member

bbatsov commented May 4, 2025

What about other var defining forms like:

  • definline
  • defrecord
  • defmacro
  • defmulti

I think they all work with private metadata.

@rrudakov
Copy link
Contributor Author

rrudakov commented May 4, 2025

What about other var defining forms like:

  • definline
  • defrecord
  • defmacro
  • defmulti

I think they all work with private metadata.

Hmm, I didn't think about it, honestly, since clojure-mode supports only def and defn. Let me try to add those as well.

@rrudakov rrudakov force-pushed the feature/cycle-privacy-refactoring branch from 142e3f7 to f48e338 Compare May 4, 2025 20:17
@rrudakov
Copy link
Contributor Author

rrudakov commented May 4, 2025

What about other var defining forms like:

  • definline
  • defrecord
  • defmacro
  • defmulti

I think they all work with private metadata.

Done.

@rrudakov rrudakov force-pushed the feature/cycle-privacy-refactoring branch from f48e338 to 1dae2e2 Compare May 4, 2025 20:30
@bbatsov bbatsov merged commit ea1c134 into clojure-emacs:main May 4, 2025
3 checks passed
@rrudakov rrudakov deleted the feature/cycle-privacy-refactoring branch May 4, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants