Draft BBS implementation #461
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbl
reviewed
Oct 17, 2023
|
|
||
| // Key generation | ||
| // https://datatracker.ietf.org/doc/html/draft-irtf-cfrg-bbs-signatures-03#name-key-generation-operations | ||
| func KeyGen(ikm []byte, keyInfo, keyDst []byte) (SecretKey, error) { |
There was a problem hiding this comment.
Given this first argument should be the output from crypto/rand.Reader, should there have an internal form for testing and then this function reads from the reader?
Contributor
Author
There was a problem hiding this comment.
Yeah, accepting a crypto/rand.Reader instead of raw bytes is better here. I passed the raw seed in for now to expedite checking against the test vectors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting as a draft to collect early feedback. I've not checked against all of the test vectors in the draft, but most of the positive cases. I'm interested in feedback on the API at this point. Function internals will be improved in the future PR. Please ignore all of the random comments and notes for myself -- a lot of them are notes to send feedback to the CFRG draft for improvement.
This branch is necessary to support prototype work for a Privacy Pass token type built on BBS.
cc @wbl, @tplooker