[WIP] STOR-5489: Implement retry loop for actor fetch requests - #7064
Open
apeacock1991 wants to merge 6 commits into
Open
[WIP] STOR-5489: Implement retry loop for actor fetch requests#7064apeacock1991 wants to merge 6 commits into
apeacock1991 wants to merge 6 commits into
Conversation
apeacock1991
force-pushed
the
apeacock/stor-5489-replay
branch
from
August 19, 2026 13:25
a40b874 to
05599f4
Compare
Use supportsActorFetchRetries() for the existing metadata capability so the name also covers replay behavior added separately.
Add a retry-preparation hook to actor fetch factories. Global actor stubs drop and recreate their channel while preserving routing inputs; replica stubs retain their pre-opened primary channel.
Move the existing actor retry metadata and factory tests into their own target. Leave body rewindability coverage isolated.
apeacock1991
force-pushed
the
apeacock/stor-5489-replay
branch
from
August 19, 2026 13:55
05599f4 to
14373e2
Compare
Merging this PR will improve performance by 9.64%
Performance Changes
Tip Curious why this is faster? Comment Comparing 
Footnotes
|
apeacock1991
force-pushed
the
apeacock/stor-5489-replay
branch
from
August 19, 2026 14:17
14373e2 to
bd4d554
Compare
Retry eligible Durable Object HTTP fetches with bounded jittered backoff while preserving logical-call metadata, rewinding request bodies, and honoring delivery, abort, and deadline semantics.
Apply Durable Object fetch replay to disconnected WebSocket upgrade handshakes while retaining the existing successful upgrade and HTTP fallback behavior.
Count the initial Durable Object fetch against the per-invocation subrequest budget, but bypass the check for physical replay attempts. This preserves one budget unit per logical fetch even when delivery is retried.
apeacock1991
force-pushed
the
apeacock/stor-5489-replay
branch
from
August 19, 2026 15:00
bd4d554 to
38a5707
Compare
apeacock1991
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[NOT READY FOR REVIEW]
When the enforcement gate is enabled, we now attempt to retry disconnected actor requests within the following bounds:
Importantly, retries do not contribute to the subrequest limit which are cumulative. This can be changed, but it felt reasonable to consider 1 req == 1 subrequest plus if we retried 5 times, that would use 10% of the subrequest budget (for free).
There's some cleanup in this PR too:
supportsActorRetryMetadatatosupportsActorFetchRetries, ultimately this is what we care about vs metadata