Skip to content

STOR-5552: Preserve in-flight WebSocket auto-responses - #7065

Open
apeacock1991 wants to merge 1 commit into
mainfrom
apeacock/STOR-5552
Open

STOR-5552: Preserve in-flight WebSocket auto-responses#7065
apeacock1991 wants to merge 1 commit into
mainfrom
apeacock/STOR-5552

Conversation

@apeacock1991

Copy link
Copy Markdown
Contributor

Track auto-response sends in the hibernation manager so revived WebSockets wait before writing.

Queue completion alongside pending responses and retain the message buffer independently of the legacy adapter. Cover direct, queued, packaged, cancellation, and repeated-revival paths.

@apeacock1991
apeacock1991 requested review from a team as code owners August 19, 2026 14:51
@ask-bonk

ask-bonk Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

LGTM

github run

Comment thread src/workerd/io/legacy-hibernation-manager.h Outdated
Comment thread src/workerd/io/legacy-hibernation-manager.c++
@codspeed-hq

codspeed-hq Bot commented Aug 19, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 9.11%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 2 improved benchmarks
✅ 70 untouched benchmarks
⏩ 129 skipped benchmarks1

Performance Changes

Benchmark BASE HEAD Efficiency
request[RegExpBenchmark] 4.5 ms 4.1 ms +9.58%
simpleStringBody[Response] 24.3 µs 22.4 µs +8.65%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing apeacock/STOR-5552 (6454b32) with main (5ef8a1f)2

Open in CodSpeed

Footnotes

  1. 129 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (7739c5e) during the generation of this report, so 5ef8a1f was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Track auto-response sends in the hibernation manager so revived
WebSockets wait before writing.

Queue completion alongside pending responses and retain the message
buffer independently of the legacy adapter. Cover direct, queued,
packaged, cancellation, and repeated-revival paths.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants