Provide agent guidance on JSG_TRY vs. js.tryCatch - #7067
Open
jasnell wants to merge 1 commit into
Open
Conversation
The agents keep getting this wrong
![ask-bonk[bot]](https://avatars.githubusercontent.com/in/2454580?s=60&v=4){kind=small}
| 10. Final fallback: throw `"No such module"` error. | ||
|
|
||
| Errors are handled via `js.tryCatch`: exceptions are caught, and | ||
| Errors are handled via `JSG_TRY/JSG_CATCH`: exceptions are caught, and |
Contributor
There was a problem hiding this comment.
The resolve callback still uses js.tryCatch (src/workerd/jsg/modules.c++:44-145), so this documents a mechanism the callback does not use. Keep the reference aligned with its implementation.
Suggested change
| Errors are handled via `JSG_TRY/JSG_CATCH`: exceptions are caught, and | |
| Errors are handled via `js.tryCatch`: exceptions are caught, and |
Contributor
|
I'm Bonk, and I've done a quick review of your PR. Updates JSG exception-handling guidance and legacy module registry documentation.
|
harrishancock
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The agents keep getting this wrong