Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(heureka): heureka old goes to ts #777

Merged
merged 5 commits into from
Feb 17, 2025
Merged

chore(heureka): heureka old goes to ts #777

merged 5 commits into from
Feb 17, 2025

Conversation

barsukov
Copy link
Contributor

Summary

Heureka old moves to TS, everything is ignored and maybe do not need to be fixed.

Changes Made

  • Heureka full ignore
  • Lint ignores

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.
  • I have created a changeset for my changes.

@barsukov barsukov added the heureka Heureka related issues label Feb 13, 2025
@barsukov barsukov self-assigned this Feb 13, 2025
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 13, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: fae56f9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudoperators/juno-app-heureka Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@barsukov barsukov changed the title Wowa heureka old goes ts chore(heureka): heureka old goes to ts Feb 13, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 13, 2025 •
edited
Loading

PR Preview Action v1.6.0
Preview removed because the pull request was closed.
2025-02-17 11:32 UTC

@barsukov barsukov marked this pull request as ready for review February 13, 2025 14:13
@barsukov barsukov requested a review from a team as a code owner February 13, 2025 14:13
hodanoori
hodanoori previously approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@hodanoori hodanoori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

andypf
andypf reviewed Feb 14, 2025
View reviewed changes
andypf
andypf approved these changes Feb 17, 2025
View reviewed changes
Copy link
Collaborator

@andypf andypf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@barsukov barsukov merged commit 188ece2 into main Feb 17, 2025
15 checks passed
@barsukov barsukov deleted the wowa-heureka-old-goes-ts branch February 17, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taymoor89 taymoor89 taymoor89 left review comments

@andypf andypf andypf approved these changes

@TilmanHaupt TilmanHaupt TilmanHaupt approved these changes

@hodanoori hodanoori hodanoori left review comments

Assignees

@barsukov barsukov

Labels
heureka Heureka related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@barsukov @andypf @taymoor89 @hodanoori @TilmanHaupt