-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(heureka): integrate GraphQL backend #779
Conversation
🦋 Changeset detectedLatest commit: b22ba0a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
0d81285
to
dfeaf5a
Compare
|
dfeaf5a
to
035330b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Taimoor. I'm wondering why preview of heureka-next is not loading for me whereas the heureka preview is coming up. Is it the same for you?
035330b
to
a53d2af
Compare
Yes I was also facing the same issue, the problem was that there was no |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job for all of us! ;)
I think we should not mock Services on tests of The shell, just write a simple tests for services...
other than that looks perfect
a53d2af
to
1c06a8c
Compare
518cae6
to
43ed710
Compare
43ed710
to
b22ba0a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Summary
This PR configures
graphql-codegen
to generate types and hooks from GraphQL Schema as well as configuresApolloClient
to communicate with the GraphQL backend.Changes Made
graphql-codegen
configured.ApolloClient
configured.Related Issues
Screenshots (if applicable)
Testing Instructions
npm i
npm run dev
Checklist