Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(heureka): integrate GraphQL backend #779

Merged
merged 3 commits into from
Feb 18, 2025
Merged

Conversation

taymoor89
Copy link
Contributor

Summary

This PR configures graphql-codegen to generate types and hooks from GraphQL Schema as well as configures ApolloClient to communicate with the GraphQL backend.

Changes Made

  • graphql-codegen configured.
  • ApolloClient configured.
  • Lists services in raw form to demonstrate successful communication.

Related Issues

Screenshots (if applicable)

Screenshot 2025-02-14 at 15 17 41

Testing Instructions

  1. npm i
  2. npm run dev

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.
  • I have created a changeset for my changes.

@taymoor89 taymoor89 requested a review from a team as a code owner February 14, 2025 14:20
Copy link

changeset-bot bot commented Feb 14, 2025

🦋 Changeset detected

Latest commit: b22ba0a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
heureka-next Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@taymoor89 taymoor89 force-pushed the wowa-hoda-heureka-codegen branch 2 times, most recently from 0d81285 to dfeaf5a Compare February 14, 2025 14:23
Copy link
Contributor

github-actions bot commented Feb 14, 2025

PR Preview Action v1.6.0
Preview removed because the pull request was closed.
2025-02-18 12:28 UTC

@taymoor89 taymoor89 force-pushed the wowa-hoda-heureka-codegen branch from dfeaf5a to 035330b Compare February 14, 2025 14:27
Copy link
Contributor

@hodanoori hodanoori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Taimoor. I'm wondering why preview of heureka-next is not loading for me whereas the heureka preview is coming up. Is it the same for you?

@taymoor89 taymoor89 force-pushed the wowa-hoda-heureka-codegen branch from 035330b to a53d2af Compare February 14, 2025 15:04
@taymoor89
Copy link
Contributor Author

Thanks Taimoor. I'm wondering why preview of heureka-next is not loading for me whereas the heureka preview is coming up. Is it the same for you?

Yes I was also facing the same issue, the problem was that there was no apiEndpoint defined. The script was unable to generate appProps.json file because we do not have HEUREKA_NEXT_APP_PROPS_BASE64 secret configured. For the moment I've reused HEUREKA_APP_PROPS_BASE64 secret because it is essentially the same but I'll talk to Arturo to help us create one.

hodanoori
hodanoori previously approved these changes Feb 14, 2025
Copy link
Contributor

@hodanoori hodanoori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@barsukov barsukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job for all of us! ;)
I think we should not mock Services on tests of The shell, just write a simple tests for services...
other than that looks perfect

@taymoor89 taymoor89 force-pushed the wowa-hoda-heureka-codegen branch 2 times, most recently from 518cae6 to 43ed710 Compare February 18, 2025 10:26
@taymoor89 taymoor89 force-pushed the wowa-hoda-heureka-codegen branch from 43ed710 to b22ba0a Compare February 18, 2025 10:27
Copy link
Contributor

@barsukov barsukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@hodanoori hodanoori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@taymoor89 taymoor89 merged commit ad03fff into main Feb 18, 2025
15 checks passed
@taymoor89 taymoor89 deleted the wowa-hoda-heureka-codegen branch February 18, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants