Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update terraform cloudposse/backup/aws to v1.0.2 #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

renovate[bot]
Copy link

@renovate renovate bot commented Dec 4, 2024

This PR contains the following updates:

Package Type Update Change
cloudposse/backup/aws (source) module patch 1.0.0 -> 1.0.2

Release Notes

cloudposse/terraform-aws-backup (cloudposse/backup/aws)

v1.0.2

Compare Source

Support for additional policy for creating reserial copies of S3 buckets @​obervinov (#​89)

what

  • Added an additional policy (AWSBackupServiceRolePolicyForS3Backup) to the IAM user being created.
  • This allows the module to be used for creating backups of S3 buckets.

why

  • Backing up S3 buckets was a missing feature necessary to fully cover the backup process through AWS Backup using this module.
  • The IAM user created by this module lacked the additional AWSBackupServiceRolePolicyForS3Backup policy needed for S3 bucket backups.

references

🤖 Automatic Updates

Update .github/settings.yml @​osterman (#​91)

what

  • Update .github/settings.yml
  • Drop .github/auto-release.yml files

why

  • Re-apply .github/settings.yml from org level
  • Use organization level auto-release settings

references

  • DEV-1242 Add protected tags with Repository Rulesets on GitHub
Update .github/settings.yml @​osterman (#​90)

what

  • Update .github/settings.yml
  • Drop .github/auto-release.yml files

why

  • Re-apply .github/settings.yml from org level
  • Use organization level auto-release settings

references

  • DEV-1242 Add protected tags with Repository Rulesets on GitHub

v1.0.1

Compare Source

fix: null value reference when copy_action is specified without lifecycle options @​carlosaml (#​86)

what

Attempt to get attribute from null value error when a copy_action is specified in a backup rule without any lifecycle options

steps to reproduce

Based on the complete example:


module "backup" {
  source = "../.."

  backup_resources = [module.efs.arn]
  not_resources    = var.not_resources

  rules = [
    {
      name              = "${module.this.name}-daily"
      schedule          = var.schedule
      start_window      = var.start_window
      completion_window = var.completion_window
      lifecycle = {
        cold_storage_after = var.cold_storage_after
        delete_after       = var.delete_after
      }
      copy_action = {
        destination_vault_arn = "arn:aws:backup:us-east-2:123456789000:backup-vault:my-vault"
      }
    }
  ]

  backup_vault_lock_configuration = {
    max_retention_days = 365
    min_retention_days = 30
  }

  context = module.this.context
}

why

The following error should not happen:

╷
│ Error: Attempt to get attribute from null value
│
│   on ../../main.tf line 79, in resource "aws_backup_plan" "default":
│   79:               cold_storage_after = rule.value.copy_action.lifecycle.cold_storage_after
│     ├────────────────
│     │ rule.value.copy_action.lifecycle is null
│
│ This value is null, so it does not have any attributes.
╵
╷
│ Error: Attempt to get attribute from null value
│
│   on ../../main.tf line 80, in resource "aws_backup_plan" "default":
│   80:               delete_after       = rule.value.copy_action.lifecycle.delete_after
│     ├────────────────
│     │ rule.value.copy_action.lifecycle is null
│
│ This value is null, so it does not have any attributes.
╵

🚀 Enhancements

chore(deps): update terraform cloudposse/dynamic-subnets/aws to v2.4.2 @​renovate (#​70)

This PR contains the following updates:

Package Type Update Change
cloudposse/dynamic-subnets/aws (source) module patch 2.4.1 -> 2.4.2

Release Notes
cloudposse/terraform-aws-dynamic-subnets (cloudposse/dynamic-subnets/aws)
v2.4.2

Compare Source

🚀 Enhancements
chore(deps): update terraform cloudposse/utils/aws to v1.4.0 (main) @​&#​8203;renovate (#&#​8203;191)

This PR contains the following updates:

Package Type Update Change
cloudposse/utils/aws (source) module minor 1.3.0 -> 1.4.0

Release Notes
cloudposse/terraform-aws-utils (cloudposse/utils/aws)
v1.4.0

Compare Source

Add il-central-1 region @​&#​8203;&#&#​8203;8203;jasonmk (#&#&#​8203;8203;31)
what

Add new Tel Aviv (il-central-1) region

why

Provide full coverage

references
Sync github @​&#​8203;&#&#​8203;8203;max-lobur (#&#&#​8203;8203;27)

Rebuild github dir from the template


🤖 Automatic Updates
chore(deps): update terraform cloudposse/utils/aws to v1.4.0 (main) @​&#​8203;renovate (#&#​8203;191)

This PR contains the following updates:

Package Type Update Change
cloudposse/utils/aws (source) module minor 1.3.0 -> 1.4.0

Release Notes
cloudposse/terraform-aws-utils (cloudposse/utils/aws)
v1.4.0

Compare Source

Add il-central-1 region @​&#​8203;&#&#​8203;8203;jasonmk (#&#&#​8203;8203;31)
what

Add new Tel Aviv (il-central-1) region

why

Provide full coverage

references
Sync github @​&#​8203;&#&#​8203;8203;max-lobur (#&#&#​8203;8203;27)

Rebuild github dir from the template


Update README.md and docs @​&#​8203;cloudpossebot (#&#​8203;189)
what

This is an auto-generated PR that updates the README.md and docs

why

To have most recent changes of README.md and doc from origin templates


🤖 Automatic Updates

chore(deps): update terraform cloudposse/dynamic-subnets/aws to v2.4.2 @​renovate (#​70)

This PR contains the following updates:

Package Type Update Change
cloudposse/dynamic-subnets/aws (source) module patch 2.4.1 -> 2.4.2

Release Notes
cloudposse/terraform-aws-dynamic-subnets (cloudposse/dynamic-subnets/aws)
v2.4.2

Compare Source

🚀 Enhancements
chore(deps): update terraform cloudposse/utils/aws to v1.4.0 (main) @​&#​8203;renovate (#&#​8203;191)

This PR contains the following updates:

Package Type Update Change
cloudposse/utils/aws (source) module minor 1.3.0 -> 1.4.0

Release Notes
cloudposse/terraform-aws-utils (cloudposse/utils/aws)
v1.4.0

Compare Source

Add il-central-1 region @​&#​8203;&#&#​8203;8203;jasonmk (#&#&#​8203;8203;31)
what

Add new Tel Aviv (il-central-1) region

why

Provide full coverage

references
Sync github @​&#​8203;&#&#​8203;8203;max-lobur (#&#&#​8203;8203;27)

Rebuild github dir from the template


🤖 Automatic Updates
chore(deps): update terraform cloudposse/utils/aws to v1.4.0 (main) @​&#​8203;renovate (#&#​8203;191)

This PR contains the following updates:

Package Type Update Change
cloudposse/utils/aws (source) module minor 1.3.0 -> 1.4.0

Release Notes
cloudposse/terraform-aws-utils (cloudposse/utils/aws)
v1.4.0

Compare Source

Add il-central-1 region @​&#​8203;&#&#​8203;8203;jasonmk (#&#&#​8203;8203;31)
what

Add new Tel Aviv (il-central-1) region

why

Provide full coverage

references
Sync github @​&#​8203;&#&#​8203;8203;max-lobur (#&#&#​8203;8203;27)

Rebuild github dir from the template


Update README.md and docs @​&#​8203;cloudpossebot (#&#​8203;189)
what

This is an auto-generated PR that updates the README.md and docs

why

To have most recent changes of README.md and doc from origin templates


Update release workflow to allow pull-requests: write @​osterman (#​84)

what

  • Update workflow (.github/workflows/release.yaml) to have permission to comment on PR

why

  • So we can support commenting on PRs with a link to the release
chore(deps): update terraform cloudposse/efs/aws to v1 @​renovate (#​68)

This PR contains the following updates:

Package Type Update Change
cloudposse/efs/aws (source) module major 0.36.0 -> 1.1.0

Release Notes
cloudposse/terraform-aws-efs (cloudposse/efs/aws)
v1.1.0

Compare Source

Make allow_all_egress a variable @​&#​8203;dlacosteGFM (#&#​8203;126)
What changes in this PR?
  • Default change is nothing (with this PR applied, nobody would have to change anything)
  • Makes a new parameter allow_all_egress which defaults to false
  • When creating the security group for the EFS volume, this line makes the security-group have an "allow egress to 0.0.0.0/0" rule entry. This PR makes that a configurable parameter instead
Why make this change?
  • EFS doesn't actually do egress, so this really makes no impact difference at all
  • ...but during a security audit we have a dangling "why do you allow egress to 0.0.0.0/0 on this?" question with no really good answer (so let's get rid of it as it doesn't do anything anyways)
References
  • PCI DSS 3.2.1 rule 1.1.7 - Requirement to review firewall and router rule sets every 6 months
  • PCI DSS 3.2.1 rule 1.2.1 - Restrict inbound and outbound traffic to that which is necessary for the environment
v1.0.0

Compare Source

🤖 Automatic Updates
chore(deps): update terraform cloudposse/security-group/aws to v2 (main) @​&#​8203;renovate (#&#​8203;135)

This PR contains the following updates:

Package Type Update Change
cloudposse/security-group/aws (source) module major 1.0.1 -> 2.2.0

Release Notes
cloudposse/terraform-aws-security-group (cloudposse/security-group/aws)
v2.2.0

Compare Source

`.editorconfig` Typo @​&#​8203;&#&#​8203;8203;milldr (#&#&#​8203;8203;50)
what

fixed intent typo

why

should be spelled "indent"

references

https://cloudposse.slack.com/archives/C01EY65H1PA/p1685638634845009

Sync github @​&#​8203;&#&#​8203;8203;max-lobur (#&#&#​8203;8203;47)

Rebuild github dir from the template

v2.1.0

Compare Source

  • No changes
v2.0.1

Compare Source

🐛 Bug Fixes
Properly handle enabled = false @​&#​8203;&#&#​8203;8203;Nuru (#&#&#​8203;8203;45)
what
  • Properly handle enabled = false
why
  • Fixes #​43
v2.0.0: Breaking changes

Compare Source

For details about migrating from v1 to v2, read the migration documentation.

Version 1 of this module had a flaw in that it tried to create new security group rules before deleting the old ones, which the Terraform provider does not handle properly and caused most attempted changes to fail. Version 2 resolves this issue by also creating a new security group when the rules change, installing the new rules in the new security group, then changing the security group assignments. Read the README and the migration documentation for more details.

Document migration from v1 to v2 @​&#​8203;&#&#​8203;8203;Nuru (#&#&#​8203;8203;42)
what
  • Document migration from v1 to v2 of this module
  • Fix #​40
why
  • Serious issues exist in v1, causing v2 to have different defaults and new settings. Documentation is needed to guide users on how to upgrade while minimizing service interruptions.
references
Fixes the link for examples/complete/main.tf @​&#​8203;&#&#​8203;8203;jdmedeiros (#&#&#​8203;8203;41)

Fixes the link for examples/complete/main.tf on the README.md file.



Update GitHub Workflows to use shared workflows from '.github' repo @​osterman (#​82)

what

  • Update workflows (.github/workflows) to use shared workflows from .github repo

why

  • Reduce nested levels of reusable workflows
Update GitHub Workflows to Fix ReviewDog TFLint Action @​osterman (#​81)

what

  • Update workflows (.github/workflows) to add issue: write permission needed by ReviewDog tflint action

why

  • The ReviewDog action will comment with line-level suggestions based on linting failures
Update GitHub workflows @​osterman (#​80)

what

  • Update workflows (.github/workflows/settings.yaml)

why

  • Support new readme generation workflow.
  • Generate banners
Use GitHub Action Workflows from `cloudposse/.github` Repo @​osterman (#​77)

what

  • Install latest GitHub Action Workflows

why

  • Use shared workflows from cldouposse/.github repository
  • Simplify management of workflows from centralized hub of configuration
Add GitHub Settings @​osterman (#​74)

what

  • Install a repository config (.github/settings.yaml)

why

  • Programmatically manage GitHub repo settings
Update Scaffolding @​osterman (#​72)

what

  • Reran make readme to rebuild README.md from README.yaml
  • Migrate to square badges
  • Add scaffolding for repo settings and Mergify

why

  • Upstream template changed in the .github repo
  • Work better with repository rulesets
  • Modernize look & feel
Update README.md and docs @​cloudpossebot (#​71)

what

This is an auto-generated PR that updates the README.md and docs

why

To have most recent changes of README.md and doc from origin templates

Update Scaffolding @​osterman (#​69)

what

  • Reran make readme to rebuild README.md from README.yaml
  • Migrate to square badges
  • Add scaffolding for repo settings and Mergify

why

  • Upstream template changed in the .github repo
  • Work better with repository rulesets
  • Modernize look & feel
Update Terraform cloudposse/efs/aws to v0.36.0 @​renovate (#​66)

This PR contains the following updates:

Package Type Update Change
cloudposse/efs/aws (source) module minor 0.35.0 -> 0.36.0

Release Notes
cloudposse/terraform-aws-efs (cloudposse/efs/aws)
v0.36.0

Compare Source

🤖 Automatic Updates
chore(deps): update terraform cloudposse/route53-cluster-hostname/aws to v0.13.0 (main) @​&#​8203;renovate (#&#​8203;136)

This PR contains the following updates:

Package Type Update Change
cloudposse/route53-cluster-hostname/aws (source) module minor 0.12.2 -> 0.13.0

Release Notes
cloudposse/terraform-aws-route53-cluster-hostname (cloudposse/route53-cluster-hostname/aws)
v0.13.0

Compare Source

  • No changes
v0.12.3

Compare Source

Add zone inputs, update tests, add usage @​&#​8203;&#&#​8203;8203;nitrocode (#&#&#​8203;8203;42)
what
  • Add zone inputs, update tests, add usage
why
  • Verify zone name exists
  • Dynamically retrieve zone name based on data source inputs
references
git.io->cloudposse.tools update @​&#​8203;&#&#​8203;8203;dylanbannon (#&#&#​8203;8203;40)
what and why

Change all references to git.io/build-harness into cloudposse.tools/build-harness, since git.io redirects will stop working on April 29th, 2022.

References
  • DEV-143

Update README.md and docs @​&#​8203;cloudpossebot (#&#​8203;131)
what

This is an auto-generated PR that updates the README.md and docs

why

To have most recent changes of README.md and doc from origin templates


Update Terraform cloudposse/vpc/aws to v2.2.0 @​renovate (#​67)

This PR contains the following updates:

Package Type Update Change
cloudposse/vpc/aws (source) module minor 2.1.1 -> 2.2.0

Release Notes
cloudposse/terraform-aws-vpc (cloudposse/vpc/aws)
v2.2.0

Compare Source


Update README.md and docs @​cloudpossebot (#​65)

what

This is an auto-generated PR that updates the README.md and docs

why

To have most recent changes of README.md and doc from origin templates

Update README.md and docs @​cloudpossebot (#​64)

what

This is an auto-generated PR that updates the README.md and docs

why

To have most recent changes of README.md and doc from origin templates

Update Terraform cloudposse/dynamic-subnets/aws to v2.4.1 @​renovate (#​62)

This PR contains the following updates:

Package Type Update Change
cloudposse/dynamic-subnets/aws (source) module minor 2.3.0 -> 2.4.1

Release Notes
cloudposse/terraform-aws-dynamic-subnets (cloudposse/dynamic-subnets/aws)
v2.4.1

Compare Source

🚀 Enhancements
Add subnet ARNs to outputs @​&#​8203;Nuru (#&#​8203;188)
what
  • Add subnet ARNs to outputs
why
v2.4.0

Compare Source

Update dependencies, remove deprecation, add NACL example @​&#​8203;Nuru (#&#​8203;184)
Note
Dropping support for deprecated EC2-Classic

With this release, EIPs allocated for NAT ingress are allocated in the default domain. This most likely does not affect you, but for accounts created before 2013-12-04 (almost 10 years ago as of this writing), the default domain could be EC2-Classic rather than the current VPC. Previously this module forced the EIPs to be in the VPC domain, but the breaking changes between AWS Provider v4 and v5 make that difficult.

If you find yourself in the rare situation where the EIPs allocated by this module are in EC2-Classic but you want them in VPC, then create the EIPs outside of this module and supply them to this module via nat_elastic_ips.

Custom NACLs

This release includes an example (examples/nacls/) showing how to create custom NACLs in conjunction with this module. Note that by default, this module creates wide-open NACLs, and subnets can only have one NACL associated with them. If you try to add a NACL to a subnet without disabling the default NACLs, you may get a possibly confusing error like:

│ Error: creating EC2 Network ACL: creating EC2 Network ACL (acl-0376c5f12dd9d784d) Association: InvalidAssociationID.NotFound: The association ID 'aclassoc-0818d5a9e3876a2bb' does not exist

See https://github.com/hashicorp/terraform-provider-aws/issues/31888

what
  • Make appropriate inputs non-nullable (treat an input of null as meaning "default")
  • Remove aws_eip vpc = true
  • Update terraform cloudposse/utils/aws to v1.3.0 (Supersedes and closes #​182)
  • Add example of how to add custom NACLs to subnets created by this module (Supersedes and closes #​176)
  • Update tests and test framework
why
  • Allow better, more consistent configuration
  • Deprecated
  • Include support for new AWS regions
  • Encourage composition of modules and resources rather than aggregation of functionality into bloated modules (c.f. #​176)
  • Stay current with features, bug fixes, and security updates
references


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from a team as a code owner December 4, 2024 05:34
@mergify mergify bot added the auto-update This PR was automatically generated label Dec 4, 2024
Copy link

mergify bot commented Dec 4, 2024

/terratest

@mergify mergify bot added the needs-test Needs testing label Dec 4, 2024
Copy link

mergify bot commented Dec 19, 2024

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟠 Require terratest

Waiting checks: test/terratest.

This rule require terratest status

  • check-success = test/terratest

Copy link

mergify bot commented Jan 3, 2025

Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳

@mergify mergify bot added the stale This PR has gone stale label Jan 3, 2025
Copy link

coderabbitai bot commented Jan 3, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mergify mergify bot removed the stale This PR has gone stale label Jan 3, 2025
Copy link

mergify bot commented Jan 10, 2025

Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳

@mergify mergify bot added stale This PR has gone stale and removed stale This PR has gone stale labels Jan 10, 2025
Copy link

mergify bot commented Jan 17, 2025

Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳

@mergify mergify bot added stale This PR has gone stale and removed stale This PR has gone stale labels Jan 17, 2025
Copy link

mergify bot commented Jan 24, 2025

Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳

@mergify mergify bot added stale This PR has gone stale and removed stale This PR has gone stale labels Jan 24, 2025
Copy link

mergify bot commented Jan 31, 2025

Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳

@mergify mergify bot added stale This PR has gone stale and removed stale This PR has gone stale labels Jan 31, 2025
Copy link

mergify bot commented Feb 7, 2025

Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳

@mergify mergify bot added stale This PR has gone stale and removed stale This PR has gone stale labels Feb 7, 2025
Copy link

mergify bot commented Feb 14, 2025

Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳

@mergify mergify bot added stale This PR has gone stale and removed stale This PR has gone stale labels Feb 14, 2025
Copy link

mergify bot commented Feb 21, 2025

Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳

@mergify mergify bot added the stale This PR has gone stale label Feb 21, 2025
@mergify mergify bot removed the stale This PR has gone stale label Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-update This PR was automatically generated needs-test Needs testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants