fix custom command invalid error sentence

cloudposse · Feb 5, 2025 · ffc48a3 · ffc48a3
1 parent d3790d0
commit ffc48a3
Show file tree

Hide file tree

Showing 5 changed files with 25 additions and 3 deletions.
diff --git a/cmd/cmd_utils.go b/cmd/cmd_utils.go
@@ -222,7 +222,7 @@ func preCustomCommand(
 		} else {
 			// truly invalid, nothing to do
 			u.PrintErrorMarkdownAndExit("Invalid command", errors.New(
-				fmt.Sprintf("no args, no steps, no sub-commands provided in config for `%s`", cmd.CommandPath()),
+				fmt.Sprintf("The `%s` command has no steps or subcommands configured.", cmd.CommandPath()),
 			), "https://atmos.tools/cli/configuration/commands")
 		}
 	}

diff --git a/tests/fixtures/scenarios/complete/atmos.yaml b/tests/fixtures/scenarios/complete/atmos.yaml
@@ -243,7 +243,8 @@ commands:
         > /dev/null
       - chmod 600 ${KUBECONFIG}
       - echo ${KUBECONFIG}
-
+  - name: "invalidCommand"
+    description: "This is an invalid command that neither has steps or sub command"
 # Integrations
 integrations:
   # Atlantis integration

diff --git a/tests/snapshots/TestCLICommands_atmos_invalidCommand.stderr.golden b/tests/snapshots/TestCLICommands_atmos_invalidCommand.stderr.golden
diff --git a/tests/snapshots/TestCLICommands_atmos_invalidCommand.stdout.golden b/tests/snapshots/TestCLICommands_atmos_invalidCommand.stdout.golden
diff --git a/tests/test-cases/complete.yaml b/tests/test-cases/complete.yaml
@@ -32,4 +32,17 @@ tests:
         - "No workflow exists"
         - "test-1"
         - "terraform-plan-all-test-components"
-      exit_code: 1
+      exit_code: 1
+  - name: atmos invalidCommand
+    enabled: true
+    snapshot: true
+    description: "Ensure atmos invalidCommand returns error"
+    workdir: "fixtures/scenarios/complete/"
+    command: "atmos"
+    args:
+      - "invalidCommand"
+    expect:
+      diff: []
+      stderr:
+        - "command has no steps or subcommands configured"
+      exit_code: 1