-
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding approval stage #117
base: main
Are you sure you want to change the base?
Conversation
Thanks @pm-trey for creating this pull request! A maintainer will review your changes shortly. Please don't be discouraged if it takes a while. While you wait, make sure to review our contributor guidelines. Tip Need help or want to ask for a PR review to be expedited?Join us on Slack in the |
@Gowiem @korenyoni Any chance on this getting merged in or should I close it? |
@pm-trey this PR would require some additional work to get merged, primarily a few things to keep it in line with Cloud Posse best practices: Using types correctly, variable naming, formatting, and README generation are the few that come to mind immediately. You can work through those issues if you want and I'd be happy to do a proper PR review, but if that sounds like a lot of work then it probably makes sense to close. I would say otherwise if there were others who were using this module and had 👍'd your PR, but it looks like there isn't many who would utilize this functionality today according to the interactions with this PR sadly. Let me know your thoughts and we can go from there -- Thanks for the follow up! |
what
Ability to have an approval stage tied to a SNS topic
why
For pipelines that require manual approval
references
N/A