Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding approval stage #117

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

pm-trey
Copy link
Contributor

@pm-trey pm-trey commented Sep 16, 2023

what

Ability to have an approval stage tied to a SNS topic

why

For pipelines that require manual approval

references

N/A

@pm-trey pm-trey requested review from a team as code owners September 16, 2023 23:32
@pm-trey pm-trey requested review from Gowiem and korenyoni September 16, 2023 23:32
@hans-d hans-d added the stale This PR has gone stale label Mar 2, 2024
Copy link

mergify bot commented Mar 9, 2024

Thanks @pm-trey for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

Tip

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

@mergify mergify bot added triage Needs triage and removed stale This PR has gone stale labels Mar 15, 2024
@pm-trey
Copy link
Contributor Author

pm-trey commented Jan 10, 2025

@Gowiem @korenyoni Any chance on this getting merged in or should I close it?

@Gowiem
Copy link
Member

Gowiem commented Jan 13, 2025

@pm-trey this PR would require some additional work to get merged, primarily a few things to keep it in line with Cloud Posse best practices: Using types correctly, variable naming, formatting, and README generation are the few that come to mind immediately.

You can work through those issues if you want and I'd be happy to do a proper PR review, but if that sounds like a lot of work then it probably makes sense to close. I would say otherwise if there were others who were using this module and had 👍'd your PR, but it looks like there isn't many who would utilize this functionality today according to the interactions with this PR sadly.

Let me know your thoughts and we can go from there -- Thanks for the follow up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Needs triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants