Skip to content

Bugfixes #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 25, 2021
Merged

Bugfixes #136

merged 2 commits into from
Oct 25, 2021

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented Oct 25, 2021

what

  • Always pass string for zone_id for route53-cluster-hostname module
  • Never pass null for security_group_id for aws_elasticache_replication_group

why

  • Errors otherwise

references

@Nuru Nuru added the bugfix Change that restores intended behavior label Oct 25, 2021
@Nuru Nuru requested review from aknysh and nitrocode October 25, 2021 22:33
@Nuru Nuru requested review from a team as code owners October 25, 2021 22:33
@Nuru
Copy link
Contributor Author

Nuru commented Oct 25, 2021

/test all

@Nuru Nuru merged commit badb311 into master Oct 25, 2021
@Nuru Nuru deleted the bugfix branch October 25, 2021 22:53
@nitrocode nitrocode mentioned this pull request Jul 7, 2022
Merged
brian-weis-msr pushed a commit to Measurabl/terraform-aws-elasticache-redis that referenced this pull request Apr 2, 2024
@Nuru @brian-weis-msr
Bugfixes (cloudposse#136)
531eb61 
* Fix cloudposse#134 use only existing security groups

* Fix cloudposse#135, default zone ID
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrocode nitrocode nitrocode approved these changes

@aknysh aknysh Awaiting requested review from aknysh

Assignees
No one assigned
Labels
bugfix Change that restores intended behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue when creating module without a security group
2 participants
@Nuru @nitrocode