Fix cloudwatch alarm failure to create (#56) #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varunpalekar
requested review from
jhosteny and
nitrocode
and removed request for
a team
varunpalekar
changed the title
vanveele
reviewed
Aug 16, 2020
Signed-off-by: Varun Palekar <[email protected]>
varunpalekar
force-pushed
the
fix/cloudwatch-alarm
branch
from
64f5fa9 to
a0ea3ba
Compare
|
/test all |
|
/terraform-fmt |
|
/test all |
|
@varunpalekar please have a look at this issue causing the tests to fail:
|
…ply (cloudposse#56) The "count" value depends on resource attributes that cannot be determined until apply. So precalculate.
varunpalekar
force-pushed
the
fix/cloudwatch-alarm
branch
from
fe8a965 to
9aa4730
Compare
|
/test all |
|
@joe-niland Thanks for the review. I updated the code respectively. |
|
/test all |
joe-niland
approved these changes
Aug 25, 2020
joe-niland
changed the title
|
Thanks for your contribution @varunpalekar. Released as https://github.com/cloudposse/terraform-aws-elasticache-redis/releases/tag/0.23.0 |
brian-weis-msr
pushed a commit
to Measurabl/terraform-aws-elasticache-redis
that referenced
this pull request
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why
references