Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Egress Outbound Variable & Updated Redis Family in Example #90

Merged
merged 3 commits into from
Dec 5, 2020
Merged

Added Egress Outbound Variable & Updated Redis Family in Example #90

merged 3 commits into from
Dec 5, 2020

Conversation

barissekerciler
Copy link
Contributor

what

  • Added cidr block option to egress traffic (default is 0.0.0.0/0)
  • Updated example with Redis 6.x

why

  • Business case (PCI-DSS). If you want to put Redis cluster to the private subnet, it shouldn't outbounds traffic to the all. At least, for a module, it must be opitonal.

@barissekerciler barissekerciler requested a review from a team as a code owner December 5, 2020 10:41
@barissekerciler barissekerciler requested review from aknysh and woz5999 and removed request for a team December 5, 2020 10:41
osterman
osterman previously approved these changes Dec 5, 2020
View reviewed changes
@osterman
Copy link
Member

osterman commented Dec 5, 2020

/test all

@joe-niland
Copy link
Member

/rebuild-readme

@joe-niland
Copy link
Member

/test all

@joe-niland joe-niland self-requested a review December 5, 2020 20:39
@joe-niland joe-niland merged commit c9fd279 into cloudposse:master Dec 5, 2020
@joe-niland
Copy link
Member

@barissekerciler thanks for your contribution!

@marcuz marcuz mentioned this pull request Dec 8, 2020
Merged
brian-weis-msr pushed a commit to Measurabl/terraform-aws-elasticache-redis that referenced this pull request Apr 2, 2024
@barissekerciler @actions-bot @brian-weis-msr
Added Egress Outbound Variable & Updated Redis Family in Example (clo…
2c01ca1 
…udposse#90)

* added eggress

* updated example

* Updated README.md

Co-authored-by: actions-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-niland joe-niland joe-niland approved these changes

@osterman osterman osterman left review comments

@aknysh aknysh Awaiting requested review from aknysh

@woz5999 woz5999 Awaiting requested review from woz5999

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@barissekerciler @osterman @joe-niland @actions-bot