Skip to content

feat: add CloudWatch event rules and add missed CloudWatch log outputs #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat: add CloudWatch event rules and add missed CloudWatch log outputs #35

wants to merge 1 commit into from

Conversation

arichtman
Copy link

what

  • add CloudWatch event rules
  • add missed CloudWatch log outputs
  • remove variable sns_subscriptions

why

  • CloudWatch event rules are useful for invoking lambda by cron expressions
  • CloudWatch log out puts are useful for external usage
  • sns_subscriptions is an unused variables

references

  • Closes #27

@arichtman arichtman requested review from a team as code owners January 6, 2023 01:40
@arichtman
Copy link
Author

This is a resubmission of #29

Gowiem
Gowiem requested changes Oct 12, 2023
View reviewed changes
variables.tf
type = map(any)
description = "Creates EventBridge (CloudWatch Events) rules for invoking the Lambda Function along with the required permissions."
default = {}
type = list(any)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update this to a list of objects here?

@Gowiem
Copy link
Member

Gowiem commented Oct 12, 2023

@arichtman sorry we've let this sit un-reviewed for so long. I can help drive it forward if you're willing to pick it back up as it looks like a good addition of functionality that we'd appreciate to get into the project. Can you pull in main locally, deal with conflicts, address feedback, and push your changes? Please ping me when it's ready and I'll be happy to review. Thanks for the contribution and I look forward to getting this in!

@Gowiem Gowiem added enhancement New feature or request minor New features that do not break anything labels Oct 12, 2023
@arichtman
Copy link
Author

@SweetOps has done the work here so far. I didn't want to steal anyone's credit so this is just a resubmission of the PR. I don't have access to this repository to make any adjustments.

@SweetOps
Copy link

I didn't want to steal anyone's credit so this is just a resubmission of the PR.

@arichtman, I do appreciate it. However, feel free to open PR from the your repo if you're still interested in these changes.

@hans-d hans-d added wip Work in Progress: Not ready for final review or merge stale This PR has gone stale and removed wip Work in Progress: Not ready for final review or merge labels Mar 8, 2024
@mergify Mergify
Copy link

mergify bot commented Mar 8, 2024

This pull request is now in conflict. Could you fix it @arichtman? 🙏

@arichtman arichtman closed this Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gowiem Gowiem Gowiem requested changes

@florian0410 florian0410 Awaiting requested review from florian0410 florian0410 is a code owner automatically assigned from cloudposse/contributors

@RothAndrew RothAndrew Awaiting requested review from RothAndrew RothAndrew is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
enhancement New feature or request minor New features that do not break anything stale This PR has gone stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arichtman @Gowiem @SweetOps @hans-d