Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix jest deprecation warnings #2748

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Conversation

just-boris
Copy link
Member

Description

Cleanup after #2718

Related links, issue #, if available: n/a

How has this been tested?

  • Build passes
  • Tested locally that typescript errors fail the build
Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

maxWorkers: os.cpus().length * (process.env.GITHUB_ACTION ? 3 : 1),
globalSetup: '<rootDir>/build-tools/integ/global-setup.js',
globalTeardown: '<rootDir>/build-tools/integ/global-teardown.js',
...integConfig,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a copy-paste config, reused it

@just-boris just-boris marked this pull request as ready for review September 20, 2024 16:59
@just-boris just-boris requested a review from a team as a code owner September 20, 2024 16:59
@just-boris just-boris requested review from Al-Dani and removed request for a team September 20, 2024 16:59
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.01%. Comparing base (8ca4c6a) to head (4341484).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2748   +/-   ##
=======================================
  Coverage   96.00%   96.01%           
=======================================
  Files         749      749           
  Lines       20900    20905    +5     
  Branches     7121     7132   +11     
=======================================
+ Hits        20066    20072    +6     
+ Misses        780      779    -1     
  Partials       54       54           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@just-boris just-boris added this pull request to the merge queue Sep 20, 2024
Merged via the queue into main with commit 7f14eff Sep 20, 2024
33 checks passed
@just-boris just-boris deleted the jest-deprecation-warnings branch September 20, 2024 19:47
guptbhum pushed a commit to guptbhum/components that referenced this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants