Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove empty file #1990

Merged
merged 2 commits into from
Jan 30, 2025
Merged

chore: remove empty file #1990

merged 2 commits into from
Jan 30, 2025

Conversation

gabriel-aranha-cw
Copy link
Contributor

@gabriel-aranha-cw gabriel-aranha-cw commented Jan 30, 2025

PR Type

Other


Description

  • Remove empty file rocks_batch_writer.rs

Changes walkthrough 📝

Relevant files
Cleanup
rocks_batch_writer.rs
Remove empty file                                                                               

src/eth/storage/permanent/rocks/rocks_batch_writer.rs

  • Deleted empty file
+0/-1     

Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • @gabriel-aranha-cw gabriel-aranha-cw marked this pull request as ready for review January 30, 2025 14:21
    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    1 similar comment
    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Copy link

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    1 similar comment
    Copy link

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @gabriel-aranha-cw gabriel-aranha-cw enabled auto-merge (squash) January 30, 2025 14:49
    @gabriel-aranha-cw gabriel-aranha-cw merged commit 017c059 into main Jan 30, 2025
    37 checks passed
    @gabriel-aranha-cw gabriel-aranha-cw deleted the chore-cleanup-empty-file branch January 30, 2025 19:10
    @gabriel-aranha-cw
    Copy link
    Contributor Author

    Final benchmark:
    Run ID: bench-1518993709

    Git Info:

    Configuration:

    • Target Account Strategy: Default

    RPS Stats: Max: 1858.00, Min: 896.00, Avg: 1684.93, StdDev: 80.18
    TPS Stats: Max: 1855.00, Min: 1470.00, Avg: 1636.35, StdDev: 82.57

    Plot: View Plot

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants