feat: (wip) implement kwok machine controller #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- implement basic deletion logic - use node spec and status in kwokmachine CR
vadasambar
commented
Jul 12, 2023
| } | ||
| } | ||
|
|
||
| // kwokMachine |
Author
There was a problem hiding this comment.
TODO: create Node here
Creating control plane machine using kwok might not be straightforward. kwok can create control plane but I am not sure if it can be represented as a Kubernetes Node resource. Another option here can be to create 1 node kind cluster and use it as a control plane Machine (this also creates dependency on the kind provider)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements kwok machine controller