Make Deno 2.0 compatible #45
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Considering to remove Opine tests, since its deps do not work with |
mainly removing the tests which handle opine. there seem to be problems, with the headers after the upgrade to Deno 2.0
Author
|
I've thrown out several tests, mainly because Opine, which seems to play a crucial role in testing is deprecated/ not executable in Deno 2.0 because of deprecated import assertions. Maybe I'll open a pull request, which addresses this issue in Opine' s repo.. Once the dep is fixed, I maybe able to run all tasks |
arnabp
added a commit
to arnabp/superdeno
that referenced
this pull request
Dec 9, 2024
Based on cmorten#45
|
Hello guys, there is any updates about merging this pull request? I still facing this issue.
|
Collaborator
|
Superceded by #47 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#46
This package is not compatible with
Deno 2.0, I made a couple changes, which make it work again.I do some doc on this branch in #46 - maybe have a look at this..
Initially I just wanted to replace the
windowVariable, withglobalThiswhich is the new Standard in Deno 2.0.The tests did not ran through - until now, after I've commented out some tests, which involve using
Opineas dependency. Also there some whitespaces, seem to appear where they shouldn't (in http headers).May need approval for workflows to run through, again.
The tests should now run through
Details
windowglobal variable to the newglobalThis.overridestatements to test and others.CheckList