Rework tiles with associator #86
Conversation
sbaldu
force-pushed
the
rework-tiles-with-associator
branch
from
e57d39e to
5eba84c
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| // these are now private members | ||
| const auto device = alpaka::getDev(queue); | ||
| alpaka::memcpy(queue, d_tiles->minMax(), min_max); |
Check warning
Code scanning / Flawfinder (reported by Codacy)
Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. Warning
| // these are now private members | ||
| const auto device = alpaka::getDev(queue); | ||
| alpaka::memcpy(queue, d_tiles->minMax(), min_max); | ||
| alpaka::memcpy(queue, d_tiles->tileSize(), tile_sizes); |
Check warning
Code scanning / Flawfinder (reported by Codacy)
Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. Warning
| #ifdef DEBUG | ||
| alpaka::memcpy(queue_, | ||
| alpaka::memcpy(queue, |
Check warning
Code scanning / Flawfinder (reported by Codacy)
Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. Warning
| clue::make_device_view(device, dev_points.view()->rho, nPoints)); | ||
| alpaka::memcpy(queue_, | ||
| clue::make_device_view(device, d_points.view()->rho, nPoints)); | ||
| alpaka::memcpy(queue, |
Check warning
Code scanning / Flawfinder (reported by Codacy)
Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. Warning
| clue::make_host_view(h_points.debugInfo().nearestHigher.data(), nPoints), | ||
| clue::make_device_view(device, dev_points.view()->nearest_higher, nPoints)); | ||
| #endif | ||
|
|
||
| alpaka::memcpy(queue_, | ||
| alpaka::memcpy(queue, |
Check warning
Code scanning / Flawfinder (reported by Codacy)
Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. Warning
| h_view->m_nbins = m_size; | ||
|
|
||
| auto queue(dev); | ||
| alpaka::memcpy(queue, m_view, h_view); |
Check warning
Code scanning / Flawfinder (reported by Codacy)
Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. Warning
| h_view->m_size = size; | ||
| h_view->m_nbins = m_size; | ||
|
|
||
| alpaka::memcpy(queue, m_view, h_view); |
Check warning
Code scanning / Flawfinder (reported by Codacy)
Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. Warning
| warp_size); | ||
|
|
||
| auto temp_offsets = make_device_buffer<uint32_t[]>(queue, m_size + 1); | ||
| alpaka::memcpy(queue, temp_offsets, m_offsets); |
Check warning
Code scanning / Flawfinder (reported by Codacy)
Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. Warning
| host_view->ntiles = n_tiles; | ||
| host_view->nperdim = n_perdim; | ||
|
|
||
| alpaka::memcpy(queue, m_view, host_view); |
Check warning
Code scanning / Flawfinder (reported by Codacy)
Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. Warning
There was a problem hiding this comment.
Cppcheck (reported by Codacy) found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
| clue::make_host_view(h_points.debugInfo().rho.data(), nPoints), | ||
| clue::make_device_view(device, dev_points.view()->rho, nPoints)); | ||
| alpaka::memcpy(queue_, | ||
| alpaka::memcpy(queue, |
Check warning
Code scanning / Flawfinder (reported by Codacy)
Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. Warning
sbaldu
force-pushed
the
rework-tiles-with-associator
branch
2 times, most recently
from
e0e52f2 to
143ac55
Compare
No description provided.