[kokkos] Work around performance issue by using only 'unsigned long' in AtomicPairCounter - #333
[kokkos] Work around performance issue by using only 'unsigned long' in AtomicPairCounter#333makortel wants to merge 2 commits into
Conversation
|
Mhm, this doesn't seem to be working as intended, at least in my test on a GTX 1080 Ti: mastermaster + #309master + #333Though I'm still at my first coffee, so I cannot guarantee there weren't any mistakes... |
|
I ran similar tests (1 thread with 1k events, and 16 threads with 20k events) on RTX 2080 SUPERmastermaster + #309master + #333GTX 1050 Timastermaster + #309master + #333Earlier I had tested only on RTX 2080 and was happy with the #333 giving similar performance as #309. But my GTX 1050 Ti test reproduces the GTX 1080 result in #333 (comment), so this appears to be a real effect. |
|
Here is a plot on V100 (~2 minutes running for each point, on the same CoriGPU node) So on Volta both fixes work, but disabling the "new atomics" yields a bit higher throughput for >= 3 concurrent events. Perhaps it would be best to go with #309 for now, and rebase this PR on top of that and leave it open for time being. |
This reverts commit 1097fee.
…in AtomicPairCounter See kokkos/kokkos#4780
b9755a1 to
0882c02
Compare
|
Rebased following the merge of #309. |

Better workaround than #309, see kokkos/kokkos#4780 for more details.
In addition, this PR adds support for using Kokkos' profiling tools via the
KOKKOS_PROFILE_LIBRARYenvironment variable. (functionality that we were missing because of heavily customized initialization of Kokkos).