Skip to content

Add PR comparison for Module Event Alloc Monitor circles plots#2775

Open
gartung wants to merge 3 commits into
cms-sw:masterfrom
gartung:gartung-module-event-alloc-mon-diff
Open

Add PR comparison for Module Event Alloc Monitor circles plots#2775
gartung wants to merge 3 commits into
cms-sw:masterfrom
gartung:gartung-module-event-alloc-mon-diff

Conversation

@gartung
Copy link
Copy Markdown
Member

@gartung gartung commented Jun 1, 2026

No description provided.

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jun 1, 2026

A new Pull Request was created by @gartung for branch master.

@akritkbehera, @cmsbuild, @iarspider, @raoatifshad, @smuzaffar can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jun 1, 2026 •
edited
Loading

cms-bot internal usage

@gartung gartung force-pushed the gartung-module-event-alloc-mon-diff branch from 1b184cb to 0ea9824 Compare June 1, 2026 15:22
@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jun 1, 2026

Pull request #2775 was updated.

@gartung gartung mentioned this pull request Jun 1, 2026
Open
@gartung gartung linked an issue Jun 1, 2026 that may be closed by this pull request
Create script to diff ModuleEventAllocMonitor circles json files for pull requests cms-sw/framework-team#2259
Open
@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jun 1, 2026

Pull request #2775 was updated.

@gartung gartung force-pushed the gartung-module-event-alloc-mon-diff branch from 5568dec to 7cbd883 Compare June 1, 2026 18:32
@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jun 1, 2026

Pull request #2775 was updated.

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jun 2, 2026

Pull request #2775 was updated.

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jun 3, 2026

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6c1606/53679/summary.html
COMMIT: cff8b5f
CMSSW: CMSSW_17_0_X_2026-06-03-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cms-bot/2775/53679/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@gartung
Copy link
Copy Markdown
Member Author

gartung commented Jun 3, 2026

enable profiling

@gartung
Copy link
Copy Markdown
Member Author

gartung commented Jun 3, 2026

please test with cms-sw/cmssw#51095

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jun 4, 2026

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6c1606/53681/summary.html
COMMIT: cff8b5f
CMSSW: CMSSW_17_0_X_2026-06-03-1100/el8_amd64_gcc13
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cms-bot/2775/53681/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 3 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 54
  • DQMHistoTests: Total histograms compared: 4316359
  • DQMHistoTests: Total failures: 63
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4316276
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 53 files compared)
  • Checked 232 log files, 203 edm output root files, 54 DQM output files
  • TriggerResults: no differences found

makortel
makortel reviewed Jun 4, 2026
View reviewed changes
Comment thread comparisons/module_event_alloc_monitor_viewer.html Outdated
Comment on lines +532 to +553
const QUANTITY_ORDER = ["added", "nAlloc", "nDealloc", "max1Alloc", "maxTemp"];
const TRANSITION_ORDER = [
"construction",
"begin job",
"begin stream",
"global begin run",
"stream begin run",
"global begin luminosity block",
"stream begin luminosity block",
"event",
"event setup",
"get next transition",
"clear event",
"global end lumi",
"global end run",
"global write lumi",
"global write run",
"write process block",
"end stream",
"end job",
"destruction",
];
Copy link
Copy Markdown
Contributor

@makortel makortel Jun 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look like ModuleAllocMonitor-specific things that do not apply to ModuleEventAllocMonitor's output.

Copy link
Copy Markdown
Member Author

@gartung gartung Jun 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. This was left over from reusing the template page for ModuleAllocMonitor.

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jun 4, 2026

Pull request #2775 was updated.

@gartung gartung force-pushed the gartung-module-event-alloc-mon-diff branch from 1c11855 to e6ec875 Compare June 4, 2026 16:23
@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jun 4, 2026

Pull request #2775 was updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@makortel makortel makortel left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

externals-pending orp-pending pending-signatures tests-pending

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create script to diff ModuleEventAllocMonitor circles json files for pull requests

3 participants

@gartung @cmsbuild @makortel