Skip to content

Add min as selectable aggregation to maxmem diff summary#2776

Open
gartung wants to merge 5 commits into
cms-sw:masterfrom
gartung:gartung-maxmem-diff-add-aggregation
Open

Add min as selectable aggregation to maxmem diff summary#2776
gartung wants to merge 5 commits into
cms-sw:masterfrom
gartung:gartung-maxmem-diff-add-aggregation

Conversation

@gartung
Copy link
Copy Markdown
Member

@gartung gartung commented Jun 1, 2026

No description provided.

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jun 1, 2026

A new Pull Request was created by @gartung for branch master.

@akritkbehera, @cmsbuild, @iarspider, @raoatifshad, @smuzaffar can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jun 1, 2026

cms-bot internal usage

@gartung
Copy link
Copy Markdown
Member Author

gartung commented Jun 1, 2026

enable profiling

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jun 1, 2026

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-509dca/53633/summary.html
COMMIT: 78fb46a
CMSSW: CMSSW_17_0_X_2026-06-01-1100/el8_amd64_gcc13
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cms-bot/2776/53633/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4199113
  • DQMHistoTests: Total failures: 24
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4199069
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 227 log files, 197 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Copy Markdown
Contributor

makortel commented Jun 2, 2026

The behavior of "min" and "max" look ok. The "max of abs" is a bit weird because it changes the negatives to positives, which is exactly as requested, but is not very useful. Would be possible to show the original (positive or negative) values in the tables, and do the sorting based on "max of abs"? If that gets too weird, we could drop the "max of abs". The "min" is already an improvement.

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jun 2, 2026

Pull request #2776 was updated.

@gartung gartung changed the title Add max,min and abs(max) as selectable aggregation to maxmem diff summary and resource diff summary Add min as selectable aggregation to maxmem diff summary Jun 2, 2026
@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jun 2, 2026

Pull request #2776 was updated.

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jun 2, 2026

Pull request #2776 was updated.

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jun 2, 2026

Pull request #2776 was updated.

@gartung
Copy link
Copy Markdown
Member Author

gartung commented Jun 2, 2026

please test

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jun 2, 2026

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-509dca/53662/summary.html
COMMIT: 7da14f0
CMSSW: CMSSW_17_0_X_2026-06-02-1100/el8_amd64_gcc13
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cms-bot/2776/53662/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 54
  • DQMHistoTests: Total histograms compared: 4316359
  • DQMHistoTests: Total failures: 30
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4316309
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 53 files compared)
  • Checked 232 log files, 203 edm output root files, 54 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Copy Markdown
Contributor

makortel commented Jun 3, 2026

Looks reasonable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add more step aggregation options for the web table

3 participants