Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrections to HGCal Cell offsets for v19 #47148

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Corrections to HGCal Cell offsets for v19 #47148

merged 1 commit into from
Jan 23, 2025

Conversation

Pruthvi-ch
Copy link
Contributor

PR description:

Correct mistakes in offset calculation script (#47077) causing compilation errors in gcc13

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

@cmsbuild cmsbuild added this to the CMSSW_15_0_X milestone Jan 21, 2025
@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 21, 2025 •
edited
Loading

cms-bot internal usage

@Pruthvi-ch Pruthvi-ch mentioned this pull request Jan 21, 2025
Merged
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47148/43378

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Pruthvi-ch for master.

It involves the following packages:

  • Geometry/HGCalCommonData (geometry, upgrade)

@Dr15Jones, @Moanwar, @bsunanda, @civanch, @cmsbuild, @kpedro88, @makortel, @mdhildreth, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@bsunanda, @fabiocos, @martinamalberti this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@Pruthvi-ch
Copy link
Contributor Author

Please Issue test command

@kpedro88
Copy link
Contributor

please test

@smuzaffar
Copy link
Contributor

please test with #47141 for el9_amd64_gcc13

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9deb95/43875/summary.html
COMMIT: 2debd56
CMSSW: CMSSW_15_0_X_2025-01-20-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47148/43875/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3819085
  • DQMHistoTests: Total failures: 65
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3819000
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 214 log files, 184 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build HeaderConsistency
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9deb95/43876/summary.html
COMMIT: 2debd56
CMSSW: CMSSW_15_0_X_2025-01-17-2300/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47148/43876/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9deb95/43876/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9deb95/43876/git-merge-result

Build

I found compilation error when building:

/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02872/el9_amd64_gcc13/external/gcc/13.2.0-b4f157aad5ba3fefd6a4401833585549/bin/c++ -c -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=130200 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DDD4HEP_USE_GEANT4_UNITS=1 -DCMSSW_GIT_HASH='CMSSW_15_0_X_2025-01-17-2300' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_15_0_X_2025-01-17-2300' -Isrc -Ipoison -I/cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el9_amd64_gcc13/cms/cmssw/CMSSW_15_0_X_2025-01-17-2300/src -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02872/el9_amd64_gcc13/external/dd4hep/v01-29-00-e4f61da0ff68a3849f52d5548357c928/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02872/el9_amd64_gcc13/external/alpaka/1.1.0-f10bd4836b58c3419918711a11f243f9/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02872/el9_amd64_gcc13/external/pcre/8.43-322dba8751ceabf66cf89a6077221d46/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02872/el9_amd64_gcc13/external/boost/1.80.0-ff08a2c59b211ca0ec6d163f98500c95/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02872/el9_amd64_gcc13/external/bz2lib/1.0.6-452db86d4d93dcf1690037af99319ec9/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02872/el9_amd64_gcc13/external/clhep/2.4.7.1-dd3c7a054bd6da4e71a71d531b36e267/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02872/el9_amd64_gcc13/external/cuda/12.4.1-1fa1a396c567d5c0a09f90633efb15e7/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02872/el9_amd64_gcc13/external/gsl/2.6-e1d9acaffa4d45817db870679c9cda91/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02872/el9_amd64_gcc13/external/libuuid/2.34-543db95ed1650444408e40e641f34da9/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02872/el9_amd64_gcc13/lcg/root/6.32.09-ea17a6f564e2abca3f9067617887df7c/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02872/el9_amd64_gcc13/external/tbb/v2021.9.0-850dff6362234ae69bb086cd105dd7eb/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02872/el9_amd64_gcc13/external/xerces-c/3.1.3-e24b915ca5dee2ac502754af591a659e/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02872/el9_amd64_gcc13/external/xz/5.2.5-b6caa493ffc2cdd51db397ec2ac3b210/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02872/el9_amd64_gcc13/external/zlib/1.2.13-33497fa85fdb17c9984295219fa199e1/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02872/el9_amd64_gcc13/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-777da7040cb89c68e8201affdcbf2aca/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02872/el9_amd64_gcc13/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-777da7040cb89c68e8201affdcbf2aca/include/eigen3 -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02872/el9_amd64_gcc13/external/fmt/10.2.1-d2066ca2935f75b53bf88bf3b87de839/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02872/el9_amd64_gcc13/external/md5/1.0.0-2f660b2cdbedb9b324f19c722f640619/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02872/el9_amd64_gcc13/external/OpenBLAS/0.3.27-066b1de6ce4eab16e12dc0e36f9bef59/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02872/el9_amd64_gcc13/external/tinyxml2/6.2.0-a65222deac81e9aef99925452e933be2/include -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++20 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -fuse-ld=bfd -march=x86-64-v3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -DEIGEN_DONT_PARALLELIZE -DEIGEN_MAX_ALIGN_BYTES=64 -Wno-error=unused-variable -DALPAKA_DEFAULT_HOST_MEMORY_ALIGNMENT=128 -DALPAKA_DISABLE_VENDOR_RNG -DBOOST_DISABLE_ASSERTS -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -fPIC -MMD -MF tmp/el9_amd64_gcc13/src/EventFilter/HGCalRawToDigi/plugins/EventFilterHGCalRawToDigiAuto/HGCalRawToDigiFake.cc.d src/EventFilter/HGCalRawToDigi/plugins/HGCalRawToDigiFake.cc -o tmp/el9_amd64_gcc13/src/EventFilter/HGCalRawToDigi/plugins/EventFilterHGCalRawToDigiAuto/HGCalRawToDigiFake.cc.o
>> Building edm plugin tmp/el9_amd64_gcc13/src/EventFilter/HGCalRawToDigi/plugins/EventFilterHGCalRawToDigiAuto/libEventFilterHGCalRawToDigiAuto.so
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02872/el9_amd64_gcc13/external/gcc/13.2.0-b4f157aad5ba3fefd6a4401833585549/bin/c++ -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++20 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -fuse-ld=bfd -march=x86-64-v3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -DEIGEN_DONT_PARALLELIZE -DEIGEN_MAX_ALIGN_BYTES=64 -Wno-error=unused-variable -DALPAKA_DEFAULT_HOST_MEMORY_ALIGNMENT=128 -DALPAKA_DISABLE_VENDOR_RNG -DBOOST_DISABLE_ASSERTS -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -shared -Wl,-E    -Wl,-z,defs     tmp/el9_amd64_gcc13/src/EventFilter/HGCalRawToDigi/plugins/EventFilterHGCalRawToDigiAuto/HFNoseRawToDigiFake.cc.o tmp/el9_amd64_gcc13/src/EventFilter/HGCalRawToDigi/plugins/EventFilterHGCalRawToDigiAuto/HGCalRawToDigi.cc.o tmp/el9_amd64_gcc13/src/EventFilter/HGCalRawToDigi/plugins/EventFilterHGCalRawToDigiAuto/HGCalRawToDigiFake.cc.o -o tmp/el9_amd64_gcc13/src/EventFilter/HGCalRawToDigi/plugins/EventFilterHGCalRawToDigiAuto/libEventFilterHGCalRawToDigiAuto.so -Wl,-E -Wl,--hash-style=gnu -Wl,--as-needed -L/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_0_X_2025-01-17-2300/biglib/el9_amd64_gcc13 -L/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_0_X_2025-01-17-2300/lib/el9_amd64_gcc13 -L/cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el9_amd64_gcc13/cms/cmssw/CMSSW_15_0_X_2025-01-17-2300/biglib/el9_amd64_gcc13 -L/cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el9_amd64_gcc13/cms/cmssw/CMSSW_15_0_X_2025-01-17-2300/lib/el9_amd64_gcc13 -L/cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el9_amd64_gcc13/cms/cmssw/CMSSW_15_0_X_2025-01-17-2300/external/el9_amd64_gcc13/lib -L/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02872/el9_amd64_gcc13/external/cuda/12.4.1-1fa1a396c567d5c0a09f90633efb15e7/lib64/stubs -L/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_0_X_2025-01-17-2300/static/el9_amd64_gcc13 -L/cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el9_amd64_gcc13/cms/cmssw/CMSSW_15_0_X_2025-01-17-2300/static/el9_amd64_gcc13 -lEventFilterHGCalRawToDigi -lCondFormatsDataRecord -lCondFormatsHGCalObjects -lGeometryHGCalCommonData -lGeometryRecords -lCondFormatsAlignmentRecord -lDataFormatsHGCDigi -lDataFormatsHGCalDigi -lDetectorDescriptionCore -lDetectorDescriptionDDCMS -lHeterogeneousCoreCUDACore -lDataFormatsForwardDetId -lDataFormatsGeometryVector -lFWCoreFramework -lHeterogeneousCoreCUDAServices -lCUDADataFormatsCommon -lDataFormatsDetId -lDataFormatsFEDRawData -lDataFormatsMath -lFWCoreCommon -lFWCoreServiceRegistry -lDataFormatsCommon -lFWCoreParameterSet -lHeterogeneousCoreCUDAUtilities -lFWCoreMessageLogger -lDataFormatsProvenance -lFWCoreConcurrency -lFWCorePluginManager -lFWCoreReflection -lHeterogeneousCoreAlpakaInterface -lCondFormatsSerialization -lFWCoreUtilities -lFWCoreVersion -lDDAlign -lDDCond -lDDCore -lDDParsers -lPhysics -lHist -lMatrix -lGenVector -lMathMore -lTree -lNet -lGeom -lThread -lMathCore -lRIO -lboost_program_options -lboost_serialization -lCore -lboost_thread -lboost_date_time -lCLHEP -lpcre -lbz2 -lcudart -lcudadevrt -lnvToolsExt -lnvidia-ml -lgsl -luuid -ltbb -lxerces-c -llzma -lz -lcuda -lfmt -lcms-md5 -lopenblas -lcrypt -ldl -lrt -lstdc++fs -ltinyxml2
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02872/el9_amd64_gcc13/external/gcc/13.2.0-b4f157aad5ba3fefd6a4401833585549/bin/../lib/gcc/x86_64-redhat-linux-gnu/13.2.0/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: cannot find -lEventFilterHGCalRawToDigi: No such file or directory
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02872/el9_amd64_gcc13/external/gcc/13.2.0-b4f157aad5ba3fefd6a4401833585549/bin/../lib/gcc/x86_64-redhat-linux-gnu/13.2.0/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: cannot find -lCondFormatsHGCalObjects: No such file or directory
collect2: error: ld returned 1 exit status
gmake: *** [tmp/el9_amd64_gcc13/src/EventFilter/HGCalRawToDigi/plugins/EventFilterHGCalRawToDigiAuto/libEventFilterHGCalRawToDigiAuto.so] Error 1
Leaving library rule at src/EventFilter/HGCalRawToDigi/plugins
Entering library rule at EventFilter/HGCalRawToDigi
>> Compiling  src/EventFilter/HGCalRawToDigi/src/HGCalUnpacker.cc
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02872/el9_amd64_gcc13/external/gcc/13.2.0-b4f157aad5ba3fefd6a4401833585549/bin/c++ -c -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=130200 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DDD4HEP_USE_GEANT4_UNITS=1 -DCMSSW_GIT_HASH='CMSSW_15_0_X_2025-01-17-2300' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_15_0_X_2025-01-17-2300' -Isrc -Ipoison -I/cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el9_amd64_gcc13/cms/cmssw/CMSSW_15_0_X_2025-01-17-2300/src -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02872/el9_amd64_gcc13/external/dd4hep/v01-29-00-e4f61da0ff68a3849f52d5548357c928/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02872/el9_amd64_gcc13/external/alpaka/1.1.0-f10bd4836b58c3419918711a11f243f9/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02872/el9_amd64_gcc13/external/pcre/8.43-322dba8751ceabf66cf89a6077221d46/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02872/el9_amd64_gcc13/external/boost/1.80.0-ff08a2c59b211ca0ec6d163f98500c95/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02872/el9_amd64_gcc13/external/bz2lib/1.0.6-452db86d4d93dcf1690037af99319ec9/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02872/el9_amd64_gcc13/external/clhep/2.4.7.1-dd3c7a054bd6da4e71a71d531b36e267/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02872/el9_amd64_gcc13/external/cuda/12.4.1-1fa1a396c567d5c0a09f90633efb15e7/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02872/el9_amd64_gcc13/external/gsl/2.6-e1d9acaffa4d45817db870679c9cda91/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02872/el9_amd64_gcc13/external/libuuid/2.34-543db95ed1650444408e40e641f34da9/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02872/el9_amd64_gcc13/lcg/root/6.32.09-ea17a6f564e2abca3f9067617887df7c/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02872/el9_amd64_gcc13/external/tbb/v2021.9.0-850dff6362234ae69bb086cd105dd7eb/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02872/el9_amd64_gcc13/external/xerces-c/3.1.3-e24b915ca5dee2ac502754af591a659e/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02872/el9_amd64_gcc13/external/xz/5.2.5-b6caa493ffc2cdd51db397ec2ac3b210/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02872/el9_amd64_gcc13/external/zlib/1.2.13-33497fa85fdb17c9984295219fa199e1/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02872/el9_amd64_gcc13/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-777da7040cb89c68e8201affdcbf2aca/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02872/el9_amd64_gcc13/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-777da7040cb89c68e8201affdcbf2aca/include/eigen3 -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02872/el9_amd64_gcc13/external/fmt/10.2.1-d2066ca2935f75b53bf88bf3b87de839/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02872/el9_amd64_gcc13/external/md5/1.0.0-2f660b2cdbedb9b324f19c722f640619/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02872/el9_amd64_gcc13/external/OpenBLAS/0.3.27-066b1de6ce4eab16e12dc0e36f9bef59/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02872/el9_amd64_gcc13/external/tinyxml2/6.2.0-a65222deac81e9aef99925452e933be2/include -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++20 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -fuse-ld=bfd -march=x86-64-v3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -DEIGEN_DONT_PARALLELIZE -DEIGEN_MAX_ALIGN_BYTES=64 -Wno-error=unused-variable -DALPAKA_DEFAULT_HOST_MEMORY_ALIGNMENT=128 -DALPAKA_DISABLE_VENDOR_RNG -DBOOST_DISABLE_ASSERTS -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -fPIC -MMD -MF tmp/el9_amd64_gcc13/src/EventFilter/HGCalRawToDigi/src/EventFilterHGCalRawToDigi/HGCalUnpacker.cc.d src/EventFilter/HGCalRawToDigi/src/HGCalUnpacker.cc -o tmp/el9_amd64_gcc13/src/EventFilter/HGCalRawToDigi/src/EventFilterHGCalRawToDigi/HGCalUnpacker.cc.o

@smuzaffar
Copy link
Contributor

@cms-sw/upgrade-l2 @cms-sw/geometry-l2 , can you please review this? This indeed fixes the el9_amd64_gcc13 build errors

@civanch
Copy link
Contributor

civanch commented Jan 23, 2025

+1

@Moanwar
Copy link
Contributor

Moanwar commented Jan 23, 2025

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 8d29cc3 into cms-sw:master Jan 23, 2025
12 of 13 checks passed
@iarspider iarspider mentioned this pull request Jan 31, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved fully-signed geometry-approved orp-approved requires-external tests-approved upgrade-approved
Projects
None yet
Milestone
CMSSW_15_0_X
Development

Successfully merging this pull request may close these issues.
7 participants
@Pruthvi-ch @cmsbuild @kpedro88 @smuzaffar @civanch @Moanwar @mandrenguyen