Use central phi functions instead LST ones

[VourMa]

With the introduction in CMSSW of alpaka functions for the computation of φ-related variables in #47033 and the related updates in #47154, these functions can be removed for the LST code and their centrally implemented equivalents can be used.

The code has been tested locally: it compiles and gives the identical results (on CPU) for LST.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47208/43485

[cmsbuild]

A new Pull Request was created by @VourMa for master.

It involves the following packages:

• RecoTracker/LSTCore (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @VinInn, @VourMa, @dgulhan, @felicepantaleo, @gpetruc, @missirol, @mmusich, @mtosi, @rovere this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[slava77]

test parameters:

• enable_tests = gpu
• workflows_gpu = 29634.704,29834.704
• workflows = 29634.703,29834.703
• relvals_opt = -w upgrade,standard
• relvals_opt_gpu = -w upgrade,standard

[slava77]

@cmsbuild please test

[cmsbuild]

+1

Size: This PR adds an extra 68KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-40ca98/44074/summary.html
COMMIT: 717caf8
CMSSW: CMSSW_15_0_X_2025-01-29-2300/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47208/44074/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 4 lines from the logs
• Reco comparison results: 160 differences found in the comparisons
• DQMHistoTests: Total files compared: 53
• DQMHistoTests: Total histograms compared: 4194999
• DQMHistoTests: Total failures: 3877
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4191102
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
• Checked 230 log files, 200 edm output root files, 53 DQM output files
• TriggerResults: no differences found

GPU Comparison Summary

Summary:

• You potentially added 1 lines to the logs
• Reco comparison results: 160 differences found in the comparisons
• DQMHistoTests: Total files compared: 9
• DQMHistoTests: Total histograms compared: 117389
• DQMHistoTests: Total failures: 1799
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 115590
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 8 files compared)
• Checked 32 log files, 36 edm output root files, 9 DQM output files
• TriggerResults: no differences found

[jfernan2]

assign heterogeneous

[jfernan2]

+1

[cmsbuild]

New categories assigned: heterogeneous

@fwyzard,@makortel you have been requested to review this Pull request/Issue and eventually sign? Thanks

[fwyzard]

+heterogeneous

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1