Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mkFit based workflow 12834.7 from short matrix #47254

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

smuzaffar
Copy link
Contributor

To avoid the [spurious differences in outputs of Run-3 wfs *.7 ( see https://github.com//issues/39803) , it is suggedted to remove worklfow 12834.7 from short/selected runTheMatrix and run it for PR tests when a PR touches tracking code ( i.e PR with tracking labels).

This PR removes the workflow 12834.7 from short/selected runTheMatrix . I will soon open a cms-bot PR to add 12834.7 for 15.0.X PR tests

FYI @makortel

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2025

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47254/43543

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2025

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@AdrianoDee, @Moanwar, @cmsbuild, @DickyChant, @miquork, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @makortel, @missirol, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2025

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47254/43544

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2025

Pull request #47254 was updated. @AdrianoDee, @Moanwar, @cmsbuild, @DickyChant, @miquork, @srimanob, @subirsarkar can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Feb 4, 2025

@smuzaffar now this has conflicts.

@smuzaffar smuzaffar force-pushed the remove-mkfit-wf-short-matrix branch from 7d18fae to cae21ab Compare February 4, 2025 10:25
@smuzaffar
Copy link
Contributor Author

@smuzaffar now this has conflicts.

resolved

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2025

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47254/43545

@smuzaffar
Copy link
Contributor Author

type tracking

@smuzaffar
Copy link
Contributor Author

please test with cms-sw/cms-bot#2430

lets rerun the tests with cms-bot PR to make sure it runs the wf 12834.7 as this PR now has tracking label

@smuzaffar
Copy link
Contributor Author

smuzaffar commented Feb 4, 2025

looks good, although bot did not run workflow 12834.7 [a] as extra relval based on tracking label (this relval is still part of short matrix in IB) but once this PR is merged then it should run 12834.7 for PRs with tracking label

[a]

WARNING: Workflow already part of default tests: 12834.7
WORKFLOWS_PR_LABELS=12434.7

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2025

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5f4b10/44178/summary.html
COMMIT: cae21ab
CMSSW: CMSSW_15_0_X_2025-02-04-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47254/44178/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2025

Milestone for this pull request has been moved to CMSSW_15_1_X. Please open a backport if it should also go in to CMSSW_15_0_X.

@cmsbuild cmsbuild modified the milestones: CMSSW_15_0_X, CMSSW_15_1_X Feb 7, 2025
@smuzaffar
Copy link
Contributor Author

@cms-sw/upgrade-l2 can you please review and sign it?

@Moanwar
Copy link
Contributor

Moanwar commented Feb 11, 2025

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cms-bot#2430

@mandrenguyen
Copy link
Contributor

+1
Based on cms-sw/cms-bot#2430 (comment)
it seems that this one should in IB before
cms-sw/cms-bot#2430

@cmsbuild cmsbuild merged commit fd5b22e into cms-sw:master Feb 12, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants