Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cmsRunGP executable to link with gperftools libprofiler.so after toolfile change #47277

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gartung
Copy link
Member

@gartung gartung commented Feb 6, 2025

@makortel
Copy link
Contributor

makortel commented Feb 6, 2025

@cmsbot

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2025

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2025

A new Pull Request was created by @gartung for master.

It involves the following packages:

  • FWCore/Framework (core)

@Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@makortel, @missirol, @wddgit this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor

makortel commented Feb 6, 2025

@cmsbuild, please test

@gartung
Copy link
Member Author

gartung commented Feb 6, 2025

@smuzaffar I made this change so libprofiler.so would be linked to cmsRunGP. Neither the use gperf or use gperf_profiler in Buildfile.xml is causing it to be linked.

@gartung
Copy link
Member Author

gartung commented Feb 6, 2025

Correction. I see -lprofiler on the link list but running ldd cmsRunGP does not show libprofiler.so.

@gartung
Copy link
Member Author

gartung commented Feb 6, 2025

abort

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2025

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2025

Pull request #47277 was updated. @Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please check and sign again.

@gartung
Copy link
Member Author

gartung commented Feb 6, 2025

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2025

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eebe94/44245/summary.html
COMMIT: 9e05cb3
CMSSW: CMSSW_15_0_X_2025-02-06-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47277/44245/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4016960
  • DQMHistoTests: Total failures: 48
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4016892
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 218 log files, 189 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@gartung
Copy link
Member Author

gartung commented Feb 6, 2025

please test with #47259, #47261 for CMSSW_15_0_ASAN_X/el8_amd64_gcc13

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2025

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eebe94/44249/summary.html
COMMIT: 9e05cb3
CMSSW: CMSSW_15_0_ASAN_X_2025-02-03-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47277/44249/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02875/el8_amd64_gcc13/external/gcc/13.3.1-92b2d78dc343ed2bc93c8eb414ddc9ff/bin/../lib/gcc/x86_64-redhat-linux-gnu/13.3.1/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: cannot find -lCalibCalorimetryHcalAlgos: No such file or directory
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02875/el8_amd64_gcc13/external/gcc/13.3.1-92b2d78dc343ed2bc93c8eb414ddc9ff/bin/../lib/gcc/x86_64-redhat-linux-gnu/13.3.1/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: cannot find -lCalibFormatsHcalObjects: No such file or directory
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02875/el8_amd64_gcc13/external/gcc/13.3.1-92b2d78dc343ed2bc93c8eb414ddc9ff/bin/../lib/gcc/x86_64-redhat-linux-gnu/13.3.1/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: cannot find -lCondFormatsHcalObjects: No such file or directory
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02875/el8_amd64_gcc13/external/gcc/13.3.1-92b2d78dc343ed2bc93c8eb414ddc9ff/bin/../lib/gcc/x86_64-redhat-linux-gnu/13.3.1/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: cannot find -lGeometryCaloTopology: No such file or directory
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02875/el8_amd64_gcc13/external/gcc/13.3.1-92b2d78dc343ed2bc93c8eb414ddc9ff/bin/../lib/gcc/x86_64-redhat-linux-gnu/13.3.1/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: cannot find -lGeometryHGCalTBCommonData: No such file or directory
collect2: error: ld returned 1 exit status
gmake: *** [tmp/el8_amd64_gcc13/src/RecoEgamma/EgammaIsolationAlgos/plugins/RecoEgammaEgammaIsolationAlgosPlugins/libRecoEgammaEgammaIsolationAlgosPlugins.so] Error 1
Leaving library rule at src/RecoEgamma/EgammaIsolationAlgos/plugins
Entering library rule at src/RecoEgamma/EgammaIsolationAlgos/plugins
>> Compiling edm plugin src/RecoEgamma/EgammaIsolationAlgos/plugins/iso_deposit_extractors/EgammaEcalExtractor.cc
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02875/el8_amd64_gcc13/external/gcc/13.3.1-92b2d78dc343ed2bc93c8eb414ddc9ff/bin/c++ -c -DCMS_MICRO_ARCH='x86-64-v3' -DGNU_GCC -D_GNU_SOURCE -DCMS_ADDRESS_SANITIZER -DTBB_USE_GLIBCXX_VERSION=130301 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DDD4HEP_USE_GEANT4_UNITS=1 -DCMSSW_GIT_HASH='CMSSW_15_0_ASAN_X_2025-02-03-1100' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_15_0_ASAN_X_2025-02-03-1100' -Isrc -Ipoison -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02875/el8_amd64_gcc13/cms/cmssw/CMSSW_15_0_ASAN_X_2025-02-03-1100/src -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02875/el8_amd64_gcc13/external/dd4hep/v01-29-00-5ae634f4b026ab0975c69e2150254b16/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02875/el8_amd64_gcc13/external/alpaka/1.2.0-6e732fbdc100bd801b75ffc9b2ec8657/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02875/el8_amd64_gcc13/external/pcre/8.43-98b91818238e6315baa782c93d2e1a8d/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02875/el8_amd64_gcc13/external/boost/1.80.0-219130170382a74ab026bc7e8f3aed50/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02875/el8_amd64_gcc13/external/bz2lib/1.0.6-f92c52f66bf6507988f946bd77fb689c/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02875/el8_amd64_gcc13/external/clhep/2.4.7.1-702cdfb6dd16a41af8674f0bf734e863/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02875/el8_amd64_gcc13/external/cuda/12.8.0-b350e6393f6f21416e3e985ecef395b9/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02875/el8_amd64_gcc13/external/gsl/2.6-1e2efc87aa19e599c5e55ee8595b7eaf/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02875/el8_amd64_gcc13/external/hls/2019.08-657cc2ffa348096ccbbe675bf0695168/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02875/el8_amd64_gcc13/external/libuuid/2.34-c2b49c79f52c48d7cb42b214bd8f95f6/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02875/el8_amd64_gcc13/lcg/root/6.32.09-673228292062580b5c2725e1de3085a5/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02875/el8_amd64_gcc13/external/tbb/v2021.9.0-fc977fda7ed4cc29c17d19c6703a0199/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02875/el8_amd64_gcc13/cms/vdt/0.4.3-857669e79ebd755e1a2c8b79a59b9bea/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02875/el8_amd64_gcc13/external/xerces-c/3.1.3-14d6230deabf01bcafd3d32c7a59dc27/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02875/el8_amd64_gcc13/external/xz/5.2.5-5f1d064218d21615d94b64b937b2e0b3/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02875/el8_amd64_gcc13/external/zlib/1.2.13-31c9b620a337e84039f8c84b7cc46501/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02875/el8_amd64_gcc13/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-f69c28fbc641f93cf8259f2f47a6ec08/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02875/el8_amd64_gcc13/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-f69c28fbc641f93cf8259f2f47a6ec08/include/eigen3 -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02875/el8_amd64_gcc13/external/fmt/10.2.1-36fc7f6c79f01f17e1a4b853aff183cd/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02875/el8_amd64_gcc13/external/md5/1.0.0-ea9ab1991fd07bc46b92ce4a79651057/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02875/el8_amd64_gcc13/external/OpenBLAS/0.3.27-b82cdf3e5810569d313c8857a6214285/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02875/el8_amd64_gcc13/external/tinyxml2/6.2.0-f3fb3ad5f8c256e1e42fc6264747acf5/include -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++20 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -fuse-ld=bfd -march=x86-64-v3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -fno-omit-frame-pointer -fsanitize=address -fsanitize=pointer-subtract -DEIGEN_DONT_PARALLELIZE -DEIGEN_MAX_ALIGN_BYTES=64 -Wno-error=unused-variable -DALPAKA_DEFAULT_HOST_MEMORY_ALIGNMENT=128 -DALPAKA_DISABLE_VENDOR_RNG -DBOOST_DISABLE_ASSERTS -fPIC -MMD -MF tmp/el8_amd64_gcc13/src/RecoEgamma/EgammaIsolationAlgos/plugins/RecoEgammaEgammaIsolationAlgosPlugins_iso_deposit_extractors/iso_deposit_extractors/EgammaEcalExtractor.cc.d src/RecoEgamma/EgammaIsolationAlgos/plugins/iso_deposit_extractors/EgammaEcalExtractor.cc -o tmp/el8_amd64_gcc13/src/RecoEgamma/EgammaIsolationAlgos/plugins/RecoEgammaEgammaIsolationAlgosPlugins_iso_deposit_extractors/iso_deposit_extractors/EgammaEcalExtractor.cc.o


@gartung
Copy link
Member Author

gartung commented Feb 6, 2025

please test for CMSSW_15_0_ASAN_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2025

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eebe94/44250/summary.html
COMMIT: 9e05cb3
CMSSW: CMSSW_15_0_ASAN_X_2025-02-05-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47277/44250/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

  • 145.301145.301_RunDisplacedJet2024E/step3_RunDisplacedJet2024E.log

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2025

Milestone for this pull request has been moved to CMSSW_15_1_X. Please open a backport if it should also go in to CMSSW_15_0_X.

@cmsbuild cmsbuild modified the milestones: CMSSW_15_0_X, CMSSW_15_1_X Feb 7, 2025
@gartung
Copy link
Member Author

gartung commented Feb 11, 2025

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eebe94/44322/summary.html
COMMIT: 9e05cb3
CMSSW: CMSSW_15_1_X_2025-02-11-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47277/44322/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4019507
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4019484
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 218 log files, 189 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@gartung gartung closed this Feb 13, 2025
@gartung gartung deleted the gartung-cmsRunGP-update branch February 13, 2025 17:28
@gartung gartung restored the gartung-cmsRunGP-update branch February 13, 2025 17:38
@gartung
Copy link
Member Author

gartung commented Feb 13, 2025

Apparently deleting branch closes pull request.

@gartung gartung reopened this Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update cmsRunGP executable to link with gperftools libprofiler.so after toolfile change
3 participants