Skip to content

prefetch data for RandomNumberGenerator#48712

Merged
cmsbuild merged 1 commit into
cms-sw:masterfrom
Dr15Jones:prefetchRandomNumberGenerator
Aug 12, 2025
Merged

prefetch data for RandomNumberGenerator#48712
cmsbuild merged 1 commit into
cms-sw:masterfrom
Dr15Jones:prefetchRandomNumberGenerator

Conversation

@Dr15Jones
Copy link
Copy Markdown
Contributor

@Dr15Jones Dr15Jones commented Aug 10, 2025

PR description:

Framework now prefetched data for RandomNumberGenerator in case of replay.

PR validation:

Framework unit tests pass.

resolves cms-sw/framework-team#1523

@Dr15Jones
Copy link
Copy Markdown
Contributor Author

please test

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Aug 10, 2025

cms-bot internal usage

@cmsbuild
Copy link
Copy Markdown
Contributor

@cmsbuild
Copy link
Copy Markdown
Contributor

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

  • FWCore/Framework (core)

@Dr15Jones, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@makortel, @missirol, @wddgit this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 44KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3fc763/47642/summary.html
COMMIT: a90e47e
CMSSW: CMSSW_15_1_X_2025-08-10-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48712/47642/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 1
  • DQMHistoTests: Total histograms compared: 0
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 0
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
  • Checked 0 log files, 0 edm output root files, 1 DQM output files

@Dr15Jones
Copy link
Copy Markdown
Contributor Author

please test

@cmsbuild
Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 44KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3fc763/47656/summary.html
COMMIT: a90e47e
CMSSW: CMSSW_15_1_X_2025-08-11-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48712/47656/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 8 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4076122
  • DQMHistoTests: Total failures: 60
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4076042
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Copy Markdown
Contributor

  • DQMHistoTests: Total histograms compared: 0

@smuzaffar Would you happen to have any idea why occasionally the PR tests compare 0 histograms? (ok I see the baseline matrix results shows nothing, so the question is then why that happens) Should I open an issue about this?

@makortel
Copy link
Copy Markdown
Contributor

Comparison differences are related to #47071 and #48504

@makortel
Copy link
Copy Markdown
Contributor

+core

@cmsbuild
Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar
Copy link
Copy Markdown
Contributor

  • DQMHistoTests: Total histograms compared: 0

@smuzaffar Would you happen to have any idea why occasionally the PR tests compare 0 histograms? (ok I see the baseline matrix results shows nothing, so the question is then why that happens) Should I open an issue about this?

@makortel , there was a bug in cms-sw/cms-bot#2507 which was causing baseline tested to silently fail (without generating any baseline). This happened when cms-sw/cms-bot#2507 was the first PR to request the generation of baseline. The bug has been identified and fixed

@makortel
Copy link
Copy Markdown
Contributor

Thanks @smuzaffar

@mandrenguyen
Copy link
Copy Markdown
Contributor

+1

@cmsbuild cmsbuild merged commit 27cacb8 into cms-sw:master Aug 12, 2025
10 checks passed
@Dr15Jones Dr15Jones deleted the prefetchRandomNumberGenerator branch August 14, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

prefetch data from RandomNumberGenerator

5 participants