prefetch data for RandomNumberGenerator#48712
Conversation
|
please test |
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48712/45754 |
|
A new Pull Request was created by @Dr15Jones for master. It involves the following packages:
@Dr15Jones, @makortel, @smuzaffar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
+1 Size: This PR adds an extra 44KB to repository Comparison SummarySummary:
|
|
please test |
|
+1 Size: This PR adds an extra 44KB to repository Comparison SummarySummary:
|
@smuzaffar Would you happen to have any idea why occasionally the PR tests compare 0 histograms? (ok I see the baseline matrix results shows nothing, so the question is then why that happens) Should I open an issue about this? |
|
+core |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
@makortel , there was a bug in cms-sw/cms-bot#2507 which was causing baseline tested to silently fail (without generating any baseline). This happened when cms-sw/cms-bot#2507 was the first PR to request the generation of baseline. The bug has been identified and fixed |
|
Thanks @smuzaffar |
|
+1 |
PR description:
Framework now prefetched data for RandomNumberGenerator in case of replay.
PR validation:
Framework unit tests pass.
resolves cms-sw/framework-team#1523