Comms: AGC + RX Fixes for Radio #297
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ibrassow
requested changes
May 26, 2025
Contributor
There was a problem hiding this comment.
Whoever is testing this (I assume @ChromeUniverse ), please post results in any form on the PR
Comment on lines
+1052
to
+1108
| self.readRegister(_SX126X_REG_AGC_RSSI_MEAS_CAL_L, temp_mv, 1) | ||
| print(f"_SX126X_REG_AGC_RSSI_MEAS_CAL_L: {temp[0]}") | ||
|
|
||
| temp = bytearray(1) | ||
| temp_mv = memoryview(temp) | ||
|
|
||
| self.readRegister(_SX126X_REG_AGC_GAIN_TUNE_1_2, temp_mv, 1) | ||
| print(f"_SX126X_REG_AGC_GAIN_TUNE_1_2: {temp[0]}") | ||
|
|
||
| temp = bytearray(1) | ||
| temp_mv = memoryview(temp) | ||
|
|
||
| self.readRegister(_SX126X_REG_AGC_GAIN_TUNE_3_4, temp_mv, 1) | ||
| print(f"_SX126X_REG_AGC_GAIN_TUNE_3_4: {temp[0]}") | ||
|
|
||
| temp = bytearray(1) | ||
| temp_mv = memoryview(temp) | ||
|
|
||
| self.readRegister(_SX126X_REG_AGC_GAIN_TUNE_5_6, temp_mv, 1) | ||
| print(f"_SX126X_REG_AGC_GAIN_TUNE_5_6: {temp[0]}") | ||
|
|
||
| temp = bytearray(1) | ||
| temp_mv = memoryview(temp) | ||
|
|
||
| self.readRegister(_SX126X_REG_AGC_GAIN_TUNE_7_8, temp_mv, 1) | ||
| print(f"_SX126X_REG_AGC_GAIN_TUNE_7_8: {temp[0]}") | ||
|
|
||
| temp = bytearray(1) | ||
| temp_mv = memoryview(temp) | ||
|
|
||
| self.readRegister(_SX126X_REG_AGC_GAIN_TUNE_9_10, temp_mv, 1) | ||
| print(f"_SX126X_REG_AGC_GAIN_TUNE_9_10: {temp[0]}") | ||
|
|
||
| temp = bytearray(1) | ||
| temp_mv = memoryview(temp) | ||
|
|
||
| self.readRegister(_SX126X_REG_AGC_GAIN_TUNE_11_12, temp_mv, 1) | ||
| print(f"_SX126X_REG_AGC_GAIN_TUNE_11_12: {temp[0]}") | ||
|
|
||
| temp = bytearray(1) | ||
| temp_mv = memoryview(temp) | ||
|
|
||
| self.readRegister(_SX126X_REG_AGC_GAIN_TUNE_13, temp_mv, 1) | ||
| print(f"_SX126X_REG_AGC_GAIN_TUNE_13: {temp[0]}") | ||
|
|
||
| temp = bytearray(1) | ||
| temp_mv = memoryview(temp) | ||
|
|
||
| self.readRegister(_SX126X_REG_AGC_G_FORST_POW_THR, temp_mv, 1) | ||
| print(f"_SX126X_REG_AGC_G_FORST_POW_THR: {temp[0]}") | ||
|
|
||
| temp = bytearray(1) | ||
| temp_mv = memoryview(temp) | ||
|
|
||
| self.readRegister(_SX126X_REG_RX_GAIN, temp_mv, 1) | ||
| print(f"_SX126X_REG_RX_GAIN: {temp[0]}") | ||
|
|
Contributor
There was a problem hiding this comment.
remove the prints before merge
Collaborator
Author
There was a problem hiding this comment.
Removed the call to this function. The function should be kept for debugging if ever needed for modifications to this whole business.
Contributor
There was a problem hiding this comment.
Still, this is not enough; I would remove the prints or comment them out. Can't make any assumption on the external function usage or that it won't be used, so need to take the precaution here
Contributor
There was a problem hiding this comment.
Anything under flight/ should be print sanitized @ChromeUniverse honestly
And honestly this belongs to scripts/ instead of the hal
Ibrassow
requested changes
Jun 30, 2025
Comment on lines
+1052
to
+1108
| self.readRegister(_SX126X_REG_AGC_RSSI_MEAS_CAL_L, temp_mv, 1) | ||
| print(f"_SX126X_REG_AGC_RSSI_MEAS_CAL_L: {temp[0]}") | ||
|
|
||
| temp = bytearray(1) | ||
| temp_mv = memoryview(temp) | ||
|
|
||
| self.readRegister(_SX126X_REG_AGC_GAIN_TUNE_1_2, temp_mv, 1) | ||
| print(f"_SX126X_REG_AGC_GAIN_TUNE_1_2: {temp[0]}") | ||
|
|
||
| temp = bytearray(1) | ||
| temp_mv = memoryview(temp) | ||
|
|
||
| self.readRegister(_SX126X_REG_AGC_GAIN_TUNE_3_4, temp_mv, 1) | ||
| print(f"_SX126X_REG_AGC_GAIN_TUNE_3_4: {temp[0]}") | ||
|
|
||
| temp = bytearray(1) | ||
| temp_mv = memoryview(temp) | ||
|
|
||
| self.readRegister(_SX126X_REG_AGC_GAIN_TUNE_5_6, temp_mv, 1) | ||
| print(f"_SX126X_REG_AGC_GAIN_TUNE_5_6: {temp[0]}") | ||
|
|
||
| temp = bytearray(1) | ||
| temp_mv = memoryview(temp) | ||
|
|
||
| self.readRegister(_SX126X_REG_AGC_GAIN_TUNE_7_8, temp_mv, 1) | ||
| print(f"_SX126X_REG_AGC_GAIN_TUNE_7_8: {temp[0]}") | ||
|
|
||
| temp = bytearray(1) | ||
| temp_mv = memoryview(temp) | ||
|
|
||
| self.readRegister(_SX126X_REG_AGC_GAIN_TUNE_9_10, temp_mv, 1) | ||
| print(f"_SX126X_REG_AGC_GAIN_TUNE_9_10: {temp[0]}") | ||
|
|
||
| temp = bytearray(1) | ||
| temp_mv = memoryview(temp) | ||
|
|
||
| self.readRegister(_SX126X_REG_AGC_GAIN_TUNE_11_12, temp_mv, 1) | ||
| print(f"_SX126X_REG_AGC_GAIN_TUNE_11_12: {temp[0]}") | ||
|
|
||
| temp = bytearray(1) | ||
| temp_mv = memoryview(temp) | ||
|
|
||
| self.readRegister(_SX126X_REG_AGC_GAIN_TUNE_13, temp_mv, 1) | ||
| print(f"_SX126X_REG_AGC_GAIN_TUNE_13: {temp[0]}") | ||
|
|
||
| temp = bytearray(1) | ||
| temp_mv = memoryview(temp) | ||
|
|
||
| self.readRegister(_SX126X_REG_AGC_G_FORST_POW_THR, temp_mv, 1) | ||
| print(f"_SX126X_REG_AGC_G_FORST_POW_THR: {temp[0]}") | ||
|
|
||
| temp = bytearray(1) | ||
| temp_mv = memoryview(temp) | ||
|
|
||
| self.readRegister(_SX126X_REG_RX_GAIN, temp_mv, 1) | ||
| print(f"_SX126X_REG_RX_GAIN: {temp[0]}") | ||
|
|
Contributor
There was a problem hiding this comment.
Still, this is not enough; I would remove the prints or comment them out. Can't make any assumption on the external function usage or that it won't be used, so need to take the precaution here
Comment on lines
+1052
to
+1108
| self.readRegister(_SX126X_REG_AGC_RSSI_MEAS_CAL_L, temp_mv, 1) | ||
| print(f"_SX126X_REG_AGC_RSSI_MEAS_CAL_L: {temp[0]}") | ||
|
|
||
| temp = bytearray(1) | ||
| temp_mv = memoryview(temp) | ||
|
|
||
| self.readRegister(_SX126X_REG_AGC_GAIN_TUNE_1_2, temp_mv, 1) | ||
| print(f"_SX126X_REG_AGC_GAIN_TUNE_1_2: {temp[0]}") | ||
|
|
||
| temp = bytearray(1) | ||
| temp_mv = memoryview(temp) | ||
|
|
||
| self.readRegister(_SX126X_REG_AGC_GAIN_TUNE_3_4, temp_mv, 1) | ||
| print(f"_SX126X_REG_AGC_GAIN_TUNE_3_4: {temp[0]}") | ||
|
|
||
| temp = bytearray(1) | ||
| temp_mv = memoryview(temp) | ||
|
|
||
| self.readRegister(_SX126X_REG_AGC_GAIN_TUNE_5_6, temp_mv, 1) | ||
| print(f"_SX126X_REG_AGC_GAIN_TUNE_5_6: {temp[0]}") | ||
|
|
||
| temp = bytearray(1) | ||
| temp_mv = memoryview(temp) | ||
|
|
||
| self.readRegister(_SX126X_REG_AGC_GAIN_TUNE_7_8, temp_mv, 1) | ||
| print(f"_SX126X_REG_AGC_GAIN_TUNE_7_8: {temp[0]}") | ||
|
|
||
| temp = bytearray(1) | ||
| temp_mv = memoryview(temp) | ||
|
|
||
| self.readRegister(_SX126X_REG_AGC_GAIN_TUNE_9_10, temp_mv, 1) | ||
| print(f"_SX126X_REG_AGC_GAIN_TUNE_9_10: {temp[0]}") | ||
|
|
||
| temp = bytearray(1) | ||
| temp_mv = memoryview(temp) | ||
|
|
||
| self.readRegister(_SX126X_REG_AGC_GAIN_TUNE_11_12, temp_mv, 1) | ||
| print(f"_SX126X_REG_AGC_GAIN_TUNE_11_12: {temp[0]}") | ||
|
|
||
| temp = bytearray(1) | ||
| temp_mv = memoryview(temp) | ||
|
|
||
| self.readRegister(_SX126X_REG_AGC_GAIN_TUNE_13, temp_mv, 1) | ||
| print(f"_SX126X_REG_AGC_GAIN_TUNE_13: {temp[0]}") | ||
|
|
||
| temp = bytearray(1) | ||
| temp_mv = memoryview(temp) | ||
|
|
||
| self.readRegister(_SX126X_REG_AGC_G_FORST_POW_THR, temp_mv, 1) | ||
| print(f"_SX126X_REG_AGC_G_FORST_POW_THR: {temp[0]}") | ||
|
|
||
| temp = bytearray(1) | ||
| temp_mv = memoryview(temp) | ||
|
|
||
| self.readRegister(_SX126X_REG_RX_GAIN, temp_mv, 1) | ||
| print(f"_SX126X_REG_RX_GAIN: {temp[0]}") | ||
|
|
Contributor
There was a problem hiding this comment.
Anything under flight/ should be print sanitized @ChromeUniverse honestly
And honestly this belongs to scripts/ instead of the hal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A (potential) software fix to the RX nonsense we have been seeing on comms for the last couple of weeks.
Implements AGC configuration according to the datasheet for the SX1262:
AGC is unconfigured in both the E22 and RFM9x drivers. However, it seems the AGC for the SX1262 (E22-400M-30S) is default configured for 915 MHz, and the SX1276 (RFM98PW) is configured for 434 MHz. This probably explains why the RFM98PW worked for previous missions.