Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixups advanced monitor CI pipeline checks #602

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/maven.yml
Original file line number Diff line number Diff line change
Expand Up @@ -538,7 +538,7 @@ jobs:
./scripts/check_histogram_results.sh results/histograms.json $ERRORS_THRESHOLD

# Running the monitor should create at least three files in the 'monitor' directory.
if ![ $(find "./results/monitor" -maxdepth 1 -mindepth 1 | wc -l) -gt 2]; then
if ! [ $(find "./results/monitor" -maxdepth 1 -mindepth 1 -type f | wc -l) -gt 2 ]; then
echo "ERROR: Advanced monitoring unsuccessful, file directory and/or appropriate files not created." >&2
exit 1
fi
Expand Down Expand Up @@ -728,7 +728,7 @@ jobs:
./scripts/check_histogram_results.sh results/histograms.json $ERRORS_THRESHOLD

# Running the monitor should create at least three files in the 'monitor' directory.
if ![ $(find "./results/monitor" -maxdepth 1 -mindepth 1 | wc -l) -gt 2]; then
if ! [ $(find "./results/monitor" -maxdepth 1 -mindepth 1 -type f | wc -l) -gt 2 ]; then
echo "ERROR: Advanced monitoring unsuccessful, file directory and/or appropriate files not created." >&2
exit 1
fi
Expand Down
10 changes: 9 additions & 1 deletion docker/build-run-benchmark-with-docker.sh
Original file line number Diff line number Diff line change
Expand Up @@ -87,12 +87,20 @@ if [ "${WITH_SERVICE_INTERRUPTIONS:-false}" == 'true' ]; then
(sleep 10 && ./scripts/interrupt-docker-db-service.sh "$BENCHBASE_PROFILE") &
fi

if [ "${WITH_ADVANCED_MONITORING:-false}" == 'true' ]; then
# Run the benchmark with advanced monitoring enabled.
mt_args="-mt advanced"
else
# Run the benchmark without monitoring.
mt_args=""
fi

rm -f results/histograms.json
BUILD_IMAGE=false EXTRA_DOCKER_ARGS="--network=host $EXTRA_DOCKER_ARGS" \
./docker/benchbase/run-full-image.sh \
--config "config/sample_${benchmark}_config.xml" --bench "$benchmark" \
--create=false --load=false --execute=true \
--sample 1 --interval-monitor 1000 \
--sample 1 --interval-monitor 1000 $mt_args \
--json-histograms results/histograms.json
rc=$?
wait # for the interrupt script, if any
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,7 @@ protected void runExtraction() {

@Override
protected void writeSystemMetrics() {
// TODO
return;
}
}
Loading