cargo fmt and actions to force format

Signed-off-by: AveryQi115 <[email protected]>

.github/workflows/rustfmt.yaml

@@ -0,0 +1,18 @@
+on: pull_request
+
+name: Rustfmt
+
+jobs:
+  format:
+    runs-on: ubuntu-latest
+    permissions:
+      pull-requests: write
+    steps:
+      - uses: actions/checkout@v4
+      - uses: dtolnay/rust-toolchain@nightly
+        with:
+          components: rustfmt
+      - uses: mbrobbel/rustfmt-check@master
+        with:
+          token: ${{ secrets.GITHUB_TOKEN }}
+          mode: review

datafusion-optd-cli/tests/cli_integration.rs

@@ -57,5 +57,8 @@ fn cli_test_tpch() {
     cmd.current_dir(".."); // all paths in `test.sql` assume we're in the base dir of the repo
     cmd.args(["--enable-logical", "--file", "tpch/test.sql"]);
     let status = cmd.status().unwrap();
-    assert!(status.success(), "should not have crashed when running tpch");
-}
+    assert!(
+        status.success(),
+        "should not have crashed when running tpch"
+    );
+}

optd-core/src/cascades/optimizer.rs

@@ -214,9 +214,7 @@ impl<T: RelNodeTyp> CascadesOptimizer<T> {
         group_id: GroupId,
         mut on_produce: impl FnMut(RelNodeRef<T>, GroupId) -> RelNodeRef<T>,
     ) -> Result<RelNodeRef<T>> {
-        self
-            .memo
-            .get_best_group_binding(group_id, &mut on_produce)
+        self.memo.get_best_group_binding(group_id, &mut on_produce)
     }
 
     fn fire_optimize_tasks(&mut self, group_id: GroupId) -> Result<()> {

optd-core/src/cascades/tasks/optimize_inputs.rs

@@ -243,12 +243,7 @@ impl<T: RelNodeTyp> Task<T> for OptimizeInputsTask {
             } else {
                 self.update_winner(
                     &cost.sum(
-                        &cost.compute_cost(
-                            &expr.typ,
-                            &expr.data,
-                            &input_cost,
-                            Some(context),
-                        ),
+                        &cost.compute_cost(&expr.typ, &expr.data, &input_cost, Some(context)),
                         &input_cost,
                     ),
                     optimizer,

optd-core/src/heuristics/optimizer.rs

@@ -49,10 +49,7 @@ fn match_node<T: RelNodeTyp>(
                 assert!(res.is_none(), "dup pick");
             }
             RuleMatcher::PickMany { pick_to } => {
-                let res = pick.insert(
-                    *pick_to,
-                    RelNode::new_list(node.children[idx..].to_vec()),
-                );
+                let res = pick.insert(*pick_to, RelNode::new_list(node.children[idx..].to_vec()));
                 assert!(res.is_none(), "dup pick");
                 should_end = true;
             }

optd-datafusion-bridge/src/from_optd.rs

@@ -351,7 +351,8 @@ impl OptdPlanContext<'_> {
             Schema::new_with_metadata(fields, HashMap::new())
         };
 
-        let physical_expr = Self::conv_from_optd_expr(node.cond(), &Arc::new(filter_schema.clone()))?;
+        let physical_expr =
+            Self::conv_from_optd_expr(node.cond(), &Arc::new(filter_schema.clone()))?;
 
         if let JoinType::Cross = node.join_type() {
             return Ok(Arc::new(CrossJoinExec::new(left_exec, right_exec))
@@ -495,7 +496,10 @@ impl OptdPlanContext<'_> {
         result.with_context(|| format!("when processing {}", rel_node_dbg))
     }
 
-    pub async fn conv_from_optd(&mut self, root_rel: OptRelNodeRef) -> Result<Arc<dyn ExecutionPlan>> {
+    pub async fn conv_from_optd(
+        &mut self,
+        root_rel: OptRelNodeRef,
+    ) -> Result<Arc<dyn ExecutionPlan>> {
         self.conv_from_optd_plan_node(PlanNode::from_rel_node(root_rel).unwrap())
             .await
     }

optd-datafusion-repr/src/rules/joins.rs

@@ -342,7 +342,7 @@ fn apply_projection_pull_up_join(
                 .into_rel_node(),
             );
         }
-        
+
         Expr::from_rel_node(
             RelNode {
                 typ: expr.typ.clone(),