fix: nulls in t-digest (#146)

**Summary**: Fixed bug where nulls appeared in t-digest. **Details:** * Fixed integration test to detect bug, then fixed bug.
cmu-db · Mar 31, 2024 · e35d508 · e35d508
1 parent 68666c4
commit e35d508
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/optd-gungnir/src/utils/arith_encoder.rs b/optd-gungnir/src/utils/arith_encoder.rs
@@ -35,7 +35,8 @@ lazy_static! {
 
 pub fn encode(string: &str) -> f64 {
     let mut left = 0.0;
-    let mut right = f64::MAX;
+    // 1000.0 is fairly arbitrary. don't make it f64::MAX though because it causes overflow in other places of the code
+    let mut right = 1000.0;
 
     for char in string.chars() {
         let cdf = CDF.get(&char).unwrap_or(&1.0);

diff --git a/optd-perftest/tests/cardtest_integration.rs b/optd-perftest/tests/cardtest_integration.rs
@@ -44,7 +44,6 @@ mod tests {
             // make sure scale factor is low so the test runs fast
             "--scale-factor",
             "0.01",
-            "--rebuild-cached-optd-stats",
             "--pguser",
             "test_user",
             "--pgpassword",