Skip to content
This repository was archived by the owner on Jan 7, 2025. It is now read-only.

feat: cargo fmt and actions to force format #62

Closed
wants to merge 3 commits into from

Conversation

AveryQi115
Copy link
Contributor

@AveryQi115 AveryQi115 commented Feb 12, 2024

  • cargo fmt current code
  • actions CI include: format check, clippy check, cargo test

@skyzh
Copy link
Member

skyzh commented Feb 12, 2024

i would not recommend auto-fix fmt. just use cargo fmt --check would be good enough :)

@skyzh
Copy link
Member

skyzh commented Feb 12, 2024

like in this case, it seems that you cannot retrieve the token...?

@AveryQi115
Copy link
Contributor Author

like in this case, it seems that you cannot retrieve the token...?

I think it is related to nightly dependencies issue?

@skyzh
Copy link
Member

skyzh commented Feb 12, 2024

i think the action you are using in rustfmt/format needs a GitHub token to add commits to the pull request.

actually i have an action file that are used across almost all my Rust projects: https://github.com/skyzh/type-exercise-in-rust/blob/main/.github/workflows/ci.yml

@skyzh
Copy link
Member

skyzh commented Feb 12, 2024

and you can pin https://github.com/cmu-db/optd/blob/main/rust-toolchain to a specific version (1.75 is the latest one?) so that there're no more fmt issues

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants