This repository was archived by the owner on Jan 7, 2025. It is now read-only.
Conversation
29 tasks
skyzh
reviewed
Feb 16, 2024
skyzh
reviewed
Feb 16, 2024
| supplier, | ||
| nation, | ||
| region | ||
| WHERE |
Member
There was a problem hiding this comment.
I feel the other team should prioritize filter push down rules otherwise join executors never get sufficient tests.
Contributor
Author
There was a problem hiding this comment.
The goal for this PR is just to ensure the queries do not crash.
AveryQi115
approved these changes
Feb 17, 2024
Contributor
AveryQi115
left a comment
AveryQi115
left a comment
There was a problem hiding this comment.
LGTM! We'll quickly add filter push down rules this weekend or early next week
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LikeExpr(it's for Q2, but it turns out Q2 requires more work)