Fix archiver bug ignoring deletions when comparing two files with no missing columns #1522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
krivard
reviewed
Feb 10, 2022
dshemetov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A partial fix of the issues in #1520.
Changelog
Previously, the archiver did not code deletions between two old-style CSVs (old-style meaning no missing columns). This changes it to always write deletions with DELETED missing columns and NAs in the missing columns for the rest of the non-missing rows. The validation and repair for the NA missing columns is then handled by the acquisition.
To be merged after cmu-delphi/delphi-epidata#862.
Fixes