Skip to content

Pin pandas below v2 #1821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2023
Merged

Pin pandas below v2 #1821

merged 1 commit into from
Apr 4, 2023

Conversation

krivard
Copy link
Contributor

@krivard krivard commented Apr 4, 2023 •
edited
Loading

Description

Temporary fix while we wait for #1820.

Pandas v2 was released on April 3 and includes breaking changes. This PR pins the version under v2.

Changelog

Itemize code/test/documentation changes and files added/removed.

  • pin pandas version in delphi-utils (which is imported by everybody, so will be transitive in all new builds)
  • add a test which fails in pandas v2. this was added while chasing down the problem, but will create a good place to start on Upgrade indicators to pandas v2.0.0 #1820.

Fixes

Fixes failing build in main

@krivard krivard requested a review from dshemetov April 4, 2023 19:47
dshemetov
dshemetov approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@dshemetov dshemetov left a comment •
edited by krivard
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! (Reiterating our Slack exchange):

  • since delphi_utils is always installed first for every indicator, this pin takes precedence over the indicator's pin (and most of the indicators pandas requirements are unpinned in the setup.py)
  • the indicators on prod have not been rebuilt with the new Pandas, so they are fine
  • when this is released, the indicators will be rebuilt with a <2 pin, so they should stay where they are now

@krivard krivard merged commit 7658724 into main Apr 4, 2023
@krivard krivard deleted the krivard/pin-pandas-m2 branch April 4, 2023 20:47
@krivard krivard mentioned this pull request Apr 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dshemetov dshemetov dshemetov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krivard @dshemetov