Fix failing hhs test and address pandas update in delphi_utils #1822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmdefries
force-pushed
the
ndefries/hhs_hosp/test-size-mismatch
branch
from
beec918 to
f6d564d
Compare
|
Superseded by #1825 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pandasgrouped-dfsumrecently changed from summing only numeric columns by default to summing all columns by default. The result is that string columns are concatenated and kept instead of being dropped, which causes anhhs_hosptest to fail and makes the geomapper return unexpected results. Change all grouped sums in the geomapper to request only numeric columns.Changelog
Fixes
Addresses #1820 for
delphi_utilsandhhs_hosp.