2130 deal with large number of null values in nssp data #2141
Conversation
There was a problem hiding this comment.
The core functionality of what you added is great!
A lot of the test stuff makes me cringe, but thats from the design that you had to inherit and build upon, so its not on you... Id love to change it all to use better paradigms, but its probably not worth it and its definitely outside the scope of this PR. I have a few suggestions on how to tighten it up though.
| """ | ||
|
|
||
| caplog.set_level(logging.WARNING) | ||
| run_as_module_empty() |
There was a problem hiding this comment.
if you put caplog before run_as_module_empty in the method arguments list, i dont think you will need to have the encapsulated definition of _run_as_module_empty (and then you wont need to execute it explicitly here)
There was a problem hiding this comment.
@minhkhul and i had a chat... this suggestion doesnt work, possibly because of how fixtures behave in general or how we are using them.
Description
Remove all null values from output csv when running nssp.
Adjust tests accordingly.
Changelog