Skip to content

Add NAN code support to CDC CovidNet #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from

Conversation

dshemetov
Copy link
Contributor

@dshemetov dshemetov commented Mar 12, 2021

Description

Work as part #838.

Changelog

  • Add three missingness columns, default to not applicable for "sample_size" and "stderr" columns
  • Code nan values in "val" column as unknown for now

Fixes

@dshemetov dshemetov mentioned this pull request Mar 12, 2021
17 tasks
@dshemetov dshemetov force-pushed the nans_cdc_covidnet branch 4 times, most recently from 52d82f6 to aefab74 Compare April 27, 2021 01:32
* update export utility to export, validate, and test the missing cols
* handle deleted rows: replaced with nan values
* handle deleted files: replace with an empty CSV file
* handle comparisons between CSVs with/without missing cols
@dshemetov dshemetov force-pushed the nans_cdc_covidnet branch from e6ed963 to 1d7903b Compare May 7, 2021 22:47
* keep nan values, add missing columns, add tests
@dshemetov dshemetov force-pushed the nans_cdc_covidnet branch from 1d7903b to 00fd4a2 Compare May 10, 2021 08:24
@dshemetov dshemetov requested review from a team and kyminbb and removed request for a team November 9, 2021 21:01
@dshemetov
Copy link
Contributor Author

@kyminbb oh, never mind on the review, looks like we don't publish this indicator.

@dshemetov dshemetov removed the request for review from kyminbb November 9, 2021 22:04
@dshemetov
Copy link
Contributor Author

Indicator doesn't exist anymore.

@dshemetov dshemetov closed this Dec 9, 2023
@dshemetov dshemetov deleted the nans_cdc_covidnet branch December 9, 2023 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant