Skip to content

Add NAN code support to Combo Indicator #944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add NAN code support to Combo Indicator #944

wants to merge 1 commit into from

Conversation

dshemetov
Copy link
Contributor

@dshemetov dshemetov commented Mar 20, 2021 •
edited
Loading

Description

Work as part #838.

Changelog

  • Allow nan values to pass through in the "val" column (in anticipation of those columns being returned from the covidcast client)
  • Add three missingness columns, default to NA for "sample_size" and "stderr" columns, set "val" to either NOT_MISSING or to UNKNOWN; if we want to be more granular, we will need to think through how geo aggregation should interact with missing codes

Fixes

@dshemetov dshemetov mentioned this pull request Mar 22, 2021
Open
17 tasks
@dshemetov dshemetov force-pushed the nans_combo branch 2 times, most recently from 79dc3d0 to 8113ae7 Compare April 27, 2021 01:33
@dshemetov
Nans combo:
44cd861 
* add missing columns and tests
@dshemetov dshemetov requested review from a team and rafaelcatoia and removed request for a team November 10, 2021 19:56
@krivard
Copy link
Contributor

krivard commented Feb 6, 2023

this PR outlived the actual combo indicator 😳

@krivard krivard closed this Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaelcatoia rafaelcatoia Awaiting requested review from rafaelcatoia rafaelcatoia was automatically assigned from cmu-delphi/covidcast-engineering

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dshemetov @krivard