Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document google-symptoms conjunctivitis signals #1614

Merged
merged 4 commits into from
Feb 28, 2025

Conversation

nmdefries
Copy link
Contributor

@nmdefries nmdefries commented Feb 28, 2025

Summary:

Closes #1613

Describe new conjunctivitis symptom set and indicators. Mention H5N1 in other parts of the page, plus some wording cleanup.

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

Copy link

@carlynvandyke carlynvandyke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I'm curious- all of the symptom sets EXCEPT the control set are now available from 2017?

@nmdefries
Copy link
Contributor Author

Thanks for the catch, @carlynvandyke!

@melange396
Copy link
Collaborator

Looks good, but I'm curious- all of the symptom sets EXCEPT the control set are now available from 2017?

the controls signals do not appear to be available before 2020 (see in epivis)

@nmdefries
Copy link
Contributor Author

the controls signals do not appear to be available before 2020

Hm, I can pull them back to Aug 2017 in epidatr. Does epivis use a date filter?

@melange396
Copy link
Collaborator

melange396 commented Feb 28, 2025

Hm, I can pull them back to Aug 2017 in epidatr. Does epivis use a date filter?

Good call! it does indeed, but i forgot about it

EDIT: issue filed @ cmu-delphi/www-epivis#92

Copy link
Collaborator

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should edit line 12, too. currently reads:

* **Earliest issue available:** November 30, 2020

@nmdefries nmdefries requested a review from melange396 February 28, 2025 20:59
@melange396 melange396 merged commit db9c6a9 into dev Feb 28, 2025
8 checks passed
@melange396 melange396 deleted the ndefries/gs-conjunctivitis branch February 28, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add google-symptoms conjunctivitis to signals spreadsheet and API documentation
3 participants