Added a few new chapters & made some minor fixes (links and such) #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dajmcdon
requested changes
Jul 15, 2023
There was a problem hiding this comment.
Not sure where this is from, but can we do the ones that have multiple aheads as geom_ribbon() instead of interval? See for example Section 10.2.
dajmcdon
requested changes
Jul 25, 2023
There was a problem hiding this comment.
In general, I think most of the language is far too informal. I made lots of comments to this effect, but I think all of it needs a read through/edit with this in mind.
I also wonder if there's a bit too much tidymodels stuff now. I like the idea of providing some background that is needed to understand how to use our package, but I'm a bit concerned that we've gone too far.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 3 new chapters
& tried to do some basic formatting to them. Also made some minor fixes (links and typos), added some of my clipart drawings, and did some minor reordering of the chapters on the left sidebar (though perhaps how to best order them & make stuff flow better from one to the next should be discussed at a future meeting).