Skip to content

deps: remove covidcast dependency #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2025
Merged

deps: remove covidcast dependency #17

merged 1 commit into from
Mar 19, 2025

Conversation

dshemetov
Copy link
Contributor

@dshemetov dshemetov commented Feb 8, 2025

Since the work in and related #7, we don't use covidcast anymore, so remove it from Suggests (it brings tons of bloated dependencies).

closes #7

@dshemetov dshemetov requested a review from nmdefries February 8, 2025 02:27
@nmdefries
Copy link
Collaborator

This looks fine so far, but I'd like to include the replacements for covidcast::state_census and covidcast::county_census here too.

@dshemetov
Copy link
Contributor Author

Oh, guess I searched wrong, I thought we removed those here already. I'll port the update later this week.

* use covidcast state_census.csv directly rather than package
@dshemetov
Copy link
Contributor Author

@nmdefries this should be ready. Turns out we were already directly loading county_census from the CSV, so only state_census was left.

@nmdefries nmdefries merged commit 0c3070b into main Mar 19, 2025
2 checks passed
@nmdefries nmdefries deleted the remove_covidcast branch March 19, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Suggests dependence on covidcast
2 participants