440 epiprocess imports #444
Conversation
…sed dplyr, tibble, tidyr
| @@ -166,7 +167,7 @@ forecasts %>% | |||
| doctor_visits %>% | |||
| epix_as_of(doctor_visits$versions_end) %>% | |||
| group_by(geo_value) %>% | |||
| tidyr::fill(percent_cli), | |||
| fill(percent_cli), | |||
There was a problem hiding this comment.
This doesn't seem to do what was intended. Maybe some sort of complete was intended beforehand?
waldo::compare(
doctor_visits %>%
epix_as_of(doctor_visits$versions_end) %>%
group_by(geo_value) %>%
fill(percent_cli)
doctor_visits %>%
epix_as_of(doctor_visits$versions_end) %>%
`attr<-`("sorted", NULL) %>%
`attr<-`(".internal.selfref", NULL) %>%
group_by(geo_value)
)
#> ✔ No differencesIt does unset some attrs that shouldn't be there... that's epiprocess#561
| @@ -160,6 +162,7 @@ export(extract_argument) | |||
| export(extract_frosting) | |||
| export(extract_layers) | |||
| export(extrapolate_quantiles) | |||
| export(filter) | |||
There was a problem hiding this comment.
musing: this does introduce a conflict with stats::filter, but I guess eventually we should be providing our own convolution utilities.
There was a problem hiding this comment.
Yeah, that will happen anytime dplyr is used. This would have happened before anyway since epiprocess was in Depends and it exports filter().
There was a problem hiding this comment.
Hmm... I'm not sure why we export filter from epiprocess; shouldn't be necessary just to provide an S3 method.
There was a problem hiding this comment.
We could make this happen only when user attaches dplyr themselves. I guess if users are using [dplyr filter] a lot [seems likely] though then it might make sense to re-export. It's just that convolution does seem somewhat popular with potential users.
Checklist
Please:
DESCRIPTIONandNEWS.md.Always increment the patch version number (the third number), unless you are
making a release PR from dev to main, in which case increment the minor
version number (the second number).
(backwards-incompatible changes to the documented interface) are noted.
Collect the changes under the next release number (e.g. if you are on
0.7.2, then write your changes under the 0.8 heading).
Change explanations for reviewer