-
Notifications
You must be signed in to change notification settings - Fork 8
Make epix_slide
more like reframe
#290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make epix_slide
more like reframe
#290
Conversation
`epix_slide` already has summarize/reframe-like column behavior: it outputs the grouping columns + columns from the user computations. Make it also have `reframe`-like row behavior: * Accept any number of elements/rows out of user computations (instead of requiring either 1 or a particular number derived from an inferred/assumed "computation effective key"). * Do not recycle length-1 user computation outputs to the "expected" length/nrow.
Previously, broadcasting in `epix_slide` would remove any rows filled in by `.drop=FALSE`, making the `.drop` setting more or less useless. Now that `epix_slide` does not broadcast, update docs&tests accordingly. Additionally, add some missing validation for the `.drop` parameter. Other changes: * Tweak code using `setDT` to do it in a pipe to read better (avoid a line setting an `out_DT` variable to a non-DT value, even temporarily). * Format some roxygen comments.
|
Sometimes we can get an
And if we want an I'm not going to try to make this easier, because it again raises questions of whether we really do want an |
This PR is based off of a branch from the wrong remote. It is replaced by #311. |
Resolves #275, addresses _pkgdown.yml typo, adds GitHub Actions checks to dev branch PRs, implements current approach to #213, adds missing
test-grouped_epi_archive.R
file.